RFR: 8264019: Use the blessed modifier order in java.xml
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the blessed modifier order. ------------- Commit messages: - Reordered final static to static final - Use the blessed modifier order in java.xml Changes: https://git.openjdk.java.net/jdk/pull/3091/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3091&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264019 Stats: 336 lines in 85 files changed: 0 ins; 0 del; 336 mod Patch: https://git.openjdk.java.net/jdk/pull/3091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3091/head:pull/3091 PR: https://git.openjdk.java.net/jdk/pull/3091
On Fri, 19 Mar 2021 16:17:40 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the blessed modifier order.
Would someone mind creating a bug for me under the parent bug JDK-8263854? ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Fri, 19 Mar 2021 23:40:00 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the blessed modifier order.
Would someone mind creating a bug for me under the parent bug JDK-8263854?
@shipilev would you mind creating a bug for me please? ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Mon, 22 Mar 2021 20:55:55 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Would someone mind creating a bug for me under the parent bug JDK-8263854?
@shipilev would you mind creating a bug for me please?
Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019 ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Tue, 23 Mar 2021 06:53:03 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@shipilev would you mind creating a bug for me please?
Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019
The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is okay, Joe Wang can say. ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Tue, 23 Mar 2021 07:24:47 GMT, Alan Bateman <alanb@openjdk.org> wrote:
Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019
The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is okay, Joe Wang can say.
Hi Alex, thanks for looking into this. As Alan mentioned, these code came from Apache, while we've made changes, we refrained from making minor ones (code style, format and etc.) as it would add unnecessary burden for future merges. I'd prefer not taking the changes to the source files that came from Apache. Thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Tue, 23 Mar 2021 17:19:10 GMT, Joe Wang <joehw@openjdk.org> wrote:
The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is okay, Joe Wang can say.
Hi Alex, thanks for looking into this. As Alan mentioned, these code came from Apache, while we've made changes, we refrained from making minor ones (code style, format and etc.) as it would add unnecessary burden for future merges. I'd prefer not taking the changes to the source files that came from Apache. Thanks.
OK, will abandon it. If someone could close the associated bug that would be appreciated. ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
On Fri, 19 Mar 2021 16:17:40 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the blessed modifier order.
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/3091
participants (4)
-
Alan Bateman
-
Aleksey Shipilev
-
Alex Blewitt
-
Joe Wang