RFR 9: [TESTBUG] 8160151: java/lang/ProcessBuilder/Zombies.java failed with error "1 zombies!"
Please review a test fix for an intermittently failing ProcessBuilder test. The test should be run in a separate vm so it only sees Zombies from processes it creates. When run in-process with jtreg, it may see Zombies from other processes created by jtreg. Additional diagnostic information is added as well in case of recurrence. The test is moved back to tier1. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-zombies-8160151/ Issue: https://bugs.openjdk.java.net/browse/JDK-8160151 Thanks, Roger
Hi Roger, Running in othervm looks good to me. The only thing I wonder about is these lines which are removed: 79 // Log remaining processes 80 ProcessBuilder pb = new ProcessBuilder("/bin/ps", "-ef"); 81 pb.inheritIO(); 82 Process p2 = pb.start(); 83 p2.waitFor(); Isn't that removing diagnostic information? best regards, -- daniel On 02/08/16 14:45, Roger Riggs wrote:
Please review a test fix for an intermittently failing ProcessBuilder test. The test should be run in a separate vm so it only sees Zombies from processes it creates. When run in-process with jtreg, it may see Zombies from other processes created by jtreg. Additional diagnostic information is added as well in case of recurrence.
The test is moved back to tier1.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-zombies-8160151/
Issue: https://bugs.openjdk.java.net/browse/JDK-8160151
Thanks, Roger
Hi Daniel, Those were added in a previous diagnostic iteration. They do a separate ps which might be too late to provide any using information. The first perl script retains and prints the suspect processes and should be enough debugging info. (There is no harm in retaining this extra info but I didn't think it was particularly useful.) Thanks, Roger On 8/2/2016 9:59 AM, Daniel Fuchs wrote:
Hi Roger,
Running in othervm looks good to me. The only thing I wonder about is these lines which are removed:
79 // Log remaining processes 80 ProcessBuilder pb = new ProcessBuilder("/bin/ps", "-ef"); 81 pb.inheritIO(); 82 Process p2 = pb.start(); 83 p2.waitFor();
Isn't that removing diagnostic information?
best regards,
-- daniel
On 02/08/16 14:45, Roger Riggs wrote:
Please review a test fix for an intermittently failing ProcessBuilder test. The test should be run in a separate vm so it only sees Zombies from processes it creates. When run in-process with jtreg, it may see Zombies from other processes created by jtreg. Additional diagnostic information is added as well in case of recurrence.
The test is moved back to tier1.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-zombies-8160151/
Issue: https://bugs.openjdk.java.net/browse/JDK-8160151
Thanks, Roger
On 02/08/16 15:03, Roger Riggs wrote:
Hi Daniel,
Those were added in a previous diagnostic iteration. They do a separate ps which might be too late to provide any using information. The first perl script retains and prints the suspect processes and should be enough debugging info. (There is no harm in retaining this extra info but I didn't think it was particularly useful.)
Thanks Roger. No issue removing this code then. +1 -- daniel
Thanks, Roger
On 8/2/2016 9:59 AM, Daniel Fuchs wrote:
Hi Roger,
Running in othervm looks good to me. The only thing I wonder about is these lines which are removed:
79 // Log remaining processes 80 ProcessBuilder pb = new ProcessBuilder("/bin/ps", "-ef"); 81 pb.inheritIO(); 82 Process p2 = pb.start(); 83 p2.waitFor();
Isn't that removing diagnostic information?
best regards,
-- daniel
On 02/08/16 14:45, Roger Riggs wrote:
Please review a test fix for an intermittently failing ProcessBuilder test. The test should be run in a separate vm so it only sees Zombies from processes it creates. When run in-process with jtreg, it may see Zombies from other processes created by jtreg. Additional diagnostic information is added as well in case of recurrence.
The test is moved back to tier1.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-zombies-8160151/
Issue: https://bugs.openjdk.java.net/browse/JDK-8160151
Thanks, Roger
participants (2)
-
Daniel Fuchs
-
Roger Riggs