RFR: 8376186: [VectorAPI] Nomenclature change for concrete vector classes
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch. In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector. All existing Vector API jtreg test are passing with the patch. Kindly review and share your feedback. Best Regards, Jatin ------------- Commit messages: - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes Changes: https://git.openjdk.org/jdk/pull/29614/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8376186 Stats: 74830 lines in 130 files changed: 31372 ins; 31371 del; 12087 mod Patch: https://git.openjdk.org/jdk/pull/29614.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29614/head:pull/29614 PR: https://git.openjdk.org/jdk/pull/29614
On Fri, 6 Feb 2026 18:33:17 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Looks good to me. Verified by: 1. Running the generators, verified the results are the same, ignoring the missing parts handled by #29616; you can integrate before that one I think. 2. Tiers 1-5 clear, only one unrelated failure from JDK-8377425. Let another engineer confirm too. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3768566495
On Fri, 6 Feb 2026 18:33:17 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Hi @PaulSandoz , Can you kindly be the second reviewer here, please check and approve this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29614#issuecomment-3866139614
On Fri, 6 Feb 2026 18:33:17 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
test/jdk/jdk/incubator/vector/gen-tests.sh line 61:
59: args="-K$type -Dtype=$type -DType=$Type -DTYPE=$TYPE" 60: 61: VectorPrefix=$Type
This seems unnecessary - why do we need it? test/jdk/jdk/incubator/vector/gen-tests.sh line 127:
125: abstractvectortype=${typeprefix}${VectorPrefix}Vector 126: abstractvectorteststype=${typeprefix}${VectorPrefix}VectorTests 127: abstractbitsvectortype=${typeprefix}${VectorPrefixe}Vector
Suggestion: abstractbitsvectortype=${typeprefix}${VectorPrefix}Vector But, why is it changed from ${Bitstype}? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2789562537 PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2789551075
On Tue, 10 Feb 2026 18:27:10 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
Review comment resolution
test/jdk/jdk/incubator/vector/gen-tests.sh line 61:
59: args="-K$type -Dtype=$type -DType=$Type -DTYPE=$TYPE" 60: 61: VectorPrefix=$Type
This seems unnecessary - why do we need it?
Removed, thanks!
test/jdk/jdk/incubator/vector/gen-tests.sh line 127:
125: abstractvectortype=${typeprefix}${VectorPrefix}Vector 126: abstractvectorteststype=${typeprefix}${VectorPrefix}VectorTests 127: abstractbitsvectortype=${typeprefix}${VectorPrefixe}Vector
Suggestion:
abstractbitsvectortype=${typeprefix}${VectorPrefix}Vector
But, why is it changed from ${Bitstype}?
Fixed! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2792539485 PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2792539345
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: Review comment resolution ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29614/files - new: https://git.openjdk.org/jdk/pull/29614/files/a5c98f86..c63c10a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=00-01 Stats: 10 lines in 1 file changed: 0 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/29614.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29614/head:pull/29614 PR: https://git.openjdk.org/jdk/pull/29614
On Wed, 11 Feb 2026 10:42:32 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
Review comment resolution
This looks good. I did a search on the code base using the regex `[\d]+Vector` and found one place. In `VectorMathLibrary` the naming convention is used in a local variable name, so we might as well update that. ------------- PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3793608325
On Thu, 12 Feb 2026 20:52:06 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
This looks good. I did a search on the code base using the regex `[\d]+Vector` and found one place. In `VectorMathLibrary` the naming convention is used in a local variable name, so we might as well update that.
Thanks @PaulSandoz , Addressed! ------------- PR Comment: https://git.openjdk.org/jdk/pull/29614#issuecomment-3895151976
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: Review comments resolution ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29614/files - new: https://git.openjdk.org/jdk/pull/29614/files/c63c10a7..8a5615d1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29614.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29614/head:pull/29614 PR: https://git.openjdk.org/jdk/pull/29614
On Fri, 13 Feb 2026 06:33:44 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
Review comments resolution
Looks good, just one last comment to address. No need for another review. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 142:
140: String suffix = suffix(vspecies); 141: String elemType = (vspecies.elementType() == float.class ? "f" : ""); 142: boolean isFloat64Vector = (vspecies.elementType() == float.class) && (vspecies.length() == 2); // FloatVector64 or FloatVectorMax
Change the variable name too, here and at line 214. ------------- PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3798632429 PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2805367818
On Fri, 13 Feb 2026 17:43:42 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
Review comments resolution
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 142:
140: String suffix = suffix(vspecies); 141: String elemType = (vspecies.elementType() == float.class ? "f" : ""); 142: boolean isFloat64Vector = (vspecies.elementType() == float.class) && (vspecies.length() == 2); // FloatVector64 or FloatVectorMax
Change the variable name too, here and at line 214.
Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2806846567
On Fri, 13 Feb 2026 17:46:14 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Looks good, just one last comment to address. No need for another review.
Hi @PaulSandoz , All comments addressed, please approve the PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29614#issuecomment-3918548235
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Reivew comments resolution - Review comments resolution - Review comment resolution - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29614/files - new: https://git.openjdk.org/jdk/pull/29614/files/8a5615d1..b56d47a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=02-03 Stats: 24658 lines in 551 files changed: 11049 ins; 3406 del; 10203 mod Patch: https://git.openjdk.org/jdk/pull/29614.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29614/head:pull/29614 PR: https://git.openjdk.org/jdk/pull/29614
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Reivew comments resolution - Review comments resolution - Review comment resolution - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29614/files - new: https://git.openjdk.org/jdk/pull/29614/files/b56d47a7..05b6cbe3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29614&range=03-04 Stats: 4221 lines in 98 files changed: 3291 ins; 415 del; 515 mod Patch: https://git.openjdk.org/jdk/pull/29614.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29614/head:pull/29614 PR: https://git.openjdk.org/jdk/pull/29614
On Wed, 18 Feb 2026 04:39:54 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
- Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Reivew comments resolution - Review comments resolution - Review comment resolution - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes
Marked as reviewed by psandoz (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3822919343
On Thu, 19 Feb 2026 00:43:14 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
- Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Reivew comments resolution - Review comments resolution - Review comment resolution - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes
Marked as reviewed by psandoz (Reviewer).
Thanks @PaulSandoz and @liach ------------- PR Comment: https://git.openjdk.org/jdk/pull/29614#issuecomment-3924949600
On Wed, 18 Feb 2026 04:39:54 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
- Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8376186 - Reivew comments resolution - Review comments resolution - Review comment resolution - Removing older artifact - 8376186: [VectorAPI] Nomenclature change for concrete vector classes
The incremental changes look good. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3823578127
On Fri, 6 Feb 2026 18:33:17 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:
As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on JDK-8370691 pull request, splitting out portion of PR#28002 into a separate patch.
In preparation of Float16 vector API support, changes to nomenclature of concrete vector class by suffixing the vector type with vector bit sizes e.g. FloatVector256 so that we don't end up generating names like Float16256Vector.
All existing Vector API jtreg test are passing with the patch.
Kindly review and share your feedback.
Best Regards, Jatin
This pull request has now been integrated. Changeset: 759fe588 Author: Jatin Bhateja <jbhateja@openjdk.org> URL: https://git.openjdk.org/jdk/commit/759fe58877ac75a9157e831cc5e54aaa70250223 Stats: 74831 lines in 131 files changed: 31371 ins; 31372 del; 12088 mod 8376186: [VectorAPI] Nomenclature change for concrete vector classes Reviewed-by: liach, psandoz ------------- PR: https://git.openjdk.org/jdk/pull/29614
participants (3)
-
Chen Liang
-
Jatin Bhateja
-
Paul Sandoz