RFR: 8241055: Regex Grapheme Matcher Performance Depends too much on Total Input Sequence Size
Hi, Any opinions on the attached patch or someone tempted to sponsor it? Regards, Philipp
I am planning to work on it. Naoto On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi,
Any opinions on the attached patch or someone tempted to sponsor it?
Regards, Philipp
Hi Philipp, I looked at the patch, and it looks good to me. As to the test case, since it is measuring the performance, I would make it in a JMH test. Maybe you would want to put it similar to open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java Minor suggestion: I would rather rename "getGraphemeType()" to just "getType()", as it is simply retrieving the character type. Naoto On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi,
Any opinions on the attached patch or someone tempted to sponsor it?
Regards, Philipp
Hi Naoto, I agree, see attached patch. Regards, Philipp On Thu, 2020-03-26 at 14:14 -0700, naoto.sato@oracle.com wrote:
Hi Philipp,
I looked at the patch, and it looks good to me. As to the test case, since it is measuring the performance, I would make it in a JMH test. Maybe you would want to put it similar to open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java
Minor suggestion: I would rather rename "getGraphemeType()" to just "getType()", as it is simply retrieving the character type.
Naoto
On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi,
Any opinions on the attached patch or someone tempted to sponsor it?
Regards, Philipp
Hi Philipp, Thanks for the update. I like you enriched the RegExTest.java. Two nits: - RegExTest.java at line 4805: I'd use parentheses for this return statement. - PatternBench.java should keep the original copyright year, i.e., "2020," -> "2019, 2020," Otherwise, it looks good. Naoto On 4/14/20 9:26 AM, Philipp Kunz wrote:
Hi Naoto,
I agree, see attached patch.
Regards, Philipp
On Thu, 2020-03-26 at 14:14 -0700, naoto.sato@oracle.com wrote:
Hi Philipp,
I looked at the patch, and it looks good to me. As to the test case, since it is measuring the performance, I would make it in a JMH test. Maybe you would want to put it similar to open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java
Minor suggestion: I would rather rename "getGraphemeType()" to just "getType()", as it is simply retrieving the character type.
Naoto
On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi,
Any opinions on the attached patch or someone tempted to sponsor it?
Regards, Philipp
Hi Naoto, Changed as you suggested.However, I could not verify it due to, most probably totally unrelated, Error: Resolution failed: Module jdk.scripting.nashorn.shell does not read a module that exports jdk.internal.editor.spi. Regards,Philipp On Wed, 2020-04-15 at 11:14 -0700, naoto.sato@oracle.com wrote:
Hi Philipp, Thanks for the update. I like you enriched the RegExTest.java. Two nits: - RegExTest.java at line 4805: I'd use parentheses for this return statement. - PatternBench.java should keep the original copyright year, i.e., "2020," -> "2019, 2020," Otherwise, it looks good. Naoto On 4/14/20 9:26 AM, Philipp Kunz wrote:
Hi Naoto, I agree, see attached patch. Regards,Philipp
On Thu, 2020-03-26 at 14:14 -0700, naoto.sato@oracle.com wrote:
Hi Philipp, I looked at the patch, and it looks good to me. As to the test case,since it is measuring the performance, I would make it in a JMH test.Maybe you would want to put it similar toopen/test/micro/org/openjdk/bench/java/util/regex/PatternBench. java Minor suggestion: I would rather rename "getGraphemeType()" to just"getType()", as it is simply retrieving the character type. Naoto On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi, Any opinions on the attached patch or someone tempted to sponsor it? Regards,Philipp
Looks good. As you noticed, the error does not seem to occur with JDK14 as bootjdk. I will push it after I confirmed OK on my side. Thank you for your contribution. Naoto On 4/16/20 12:26 PM, Philipp Kunz wrote:
Hi Naoto,
Changed as you suggested. However, I could not verify it due to, most probably totally unrelated, Error: Resolution failed: Module jdk.scripting.nashorn.shell does not read a module that exports jdk.internal.editor.spi.
Regards, Philipp
On Wed, 2020-04-15 at 11:14 -0700, naoto.sato@oracle.com wrote:
Hi Philipp,
Thanks for the update. I like you enriched the RegExTest.java. Two nits:
- RegExTest.java at line 4805: I'd use parentheses for this return statement.
- PatternBench.java should keep the original copyright year, i.e., "2020," -> "2019, 2020,"
Otherwise, it looks good.
Naoto
On 4/14/20 9:26 AM, Philipp Kunz wrote:
Hi Naoto,
I agree, see attached patch.
Regards, Philipp
On Thu, 2020-03-26 at 14:14 -0700, naoto.sato@oracle.com <mailto:naoto.sato@oracle.com> wrote:
Hi Philipp,
I looked at the patch, and it looks good to me. As to the test case, since it is measuring the performance, I would make it in a JMH test. Maybe you would want to put it similar to open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java
Minor suggestion: I would rather rename "getGraphemeType()" to just "getType()", as it is simply retrieving the character type.
Naoto
On 3/21/20 7:58 AM, Philipp Kunz wrote:
Hi,
Any opinions on the attached patch or someone tempted to sponsor it?
Regards, Philipp
participants (2)
-
naoto.sato＠oracle.com
-
Philipp Kunz