RFR: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method. In both constructors, add the following to the paragraph the describes invoking the factory: * When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed. ------------- Commit messages: - 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. Changes: https://git.openjdk.java.net/jdk/pull/6704/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6704&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278044 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6704.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6704/head:pull/6704 PR: https://git.openjdk.java.net/jdk/pull/6704
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking the factory:
* When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed.
Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Clarified that a runtime exception may be thrown by the filter factory returned from `ObjectInputFilter.Config.getSerialFilterFactory()` not by the `getSerialFilterFactory` method. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6704/files - new: https://git.openjdk.java.net/jdk/pull/6704/files/ecb9aa90..da95d900 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6704&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6704&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6704.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6704/head:pull/6704 PR: https://git.openjdk.java.net/jdk/pull/6704
On Mon, 6 Dec 2021 16:01:43 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking the factory:
* When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed.
Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
Clarified that a runtime exception may be thrown by the filter factory returned from `ObjectInputFilter.Config.getSerialFilterFactory()` not by the `getSerialFilterFactory` method.
Marked as reviewed by lancea (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6704
On Mon, 6 Dec 2021 16:01:43 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking the factory:
* When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed.
Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
Clarified that a runtime exception may be thrown by the filter factory returned from `ObjectInputFilter.Config.getSerialFilterFactory()` not by the `getSerialFilterFactory` method.
Marked as reviewed by bpb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6704
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking the factory:
* When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed.
Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into 8278044-factory-runtime-exceptions - Merge branch 'master' into 8278044-factory-runtime-exceptions - Clarified that a runtime exception may be thrown by the filter factory returned from `ObjectInputFilter.Config.getSerialFilterFactory()` not by the `getSerialFilterFactory` method. - 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. ------------- Changes: https://git.openjdk.java.net/jdk/pull/6704/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6704&range=02 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6704.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6704/head:pull/6704 PR: https://git.openjdk.java.net/jdk/pull/6704
On Fri, 3 Dec 2021 16:16:30 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking the factory:
* When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed.
This pull request has now been integrated. Changeset: 8c0bb53f Author: Roger Riggs <rriggs@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/8c0bb53f5ba6e71b81c9cb99e6f1587150fe... Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. Reviewed-by: lancea, bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/6704
participants (3)
-
Brian Burkhalter
-
Lance Andersen
-
Roger Riggs