RFR: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem
Problematic paths that start with /modules/modules prefix are handled properly ------------- Commit messages: - fixed typos in comments - 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem Changes: https://git.openjdk.java.net/jdk/pull/4022/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4022&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266291 Stats: 36 lines in 2 files changed: 32 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/4022.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4022/head:pull/4022 PR: https://git.openjdk.java.net/jdk/pull/4022
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
Problematic paths that start with /modules/modules prefix are handled properly
LGTM ------------- Marked as reviewed by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4022
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
Problematic paths that start with /modules/modules prefix are handled properly
Marked as reviewed by alanb (Reviewer). src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 475:
473: } 474: // Make sure that the thing that follows "/modules/" is a module name. 475: // This will rule out paths that start as "/modules/modules/".
The code change looks fine. I guess I would probably change the comment to say that it make sure that there is something ending with "/" after "/modules/" (as the code that it comments doesn't actually change for a module name). ------------- PR: https://git.openjdk.java.net/jdk/pull/4022
Problematic paths that start with /modules/modules prefix are handled properly
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: edited comment as per code review. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4022/files - new: https://git.openjdk.java.net/jdk/pull/4022/files/ba288d93..92611cbb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4022&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4022&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4022.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4022/head:pull/4022 PR: https://git.openjdk.java.net/jdk/pull/4022
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
Problematic paths that start with /modules/modules prefix are handled properly
This pull request has now been integrated. Changeset: af4cd04c Author: Athijegannathan Sundararajan <sundar@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/af4cd04c2e393f8d1ffef60f49e3269adee6... Stats: 35 lines in 2 files changed: 31 ins; 0 del; 4 mod 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem Reviewed-by: redestad, alanb ------------- PR: https://git.openjdk.java.net/jdk/pull/4022
participants (3)
-
Alan Bateman
-
Athijegannathan Sundararajan
-
Claes Redestad