RFR: 8265019 : Update tests for additional TestNG test permissions
Hi all, Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG. Best, Lance ------------- Commit messages: - TestNG updates Changes: https://git.openjdk.java.net/jdk/pull/3471/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3471&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265019 Stats: 21 lines in 2 files changed: 11 ins; 6 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3471.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3471/head:pull/3471 PR: https://git.openjdk.java.net/jdk/pull/3471
On Tue, 13 Apr 2021 18:01:49 GMT, Lance Andersen <lancea@openjdk.org> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
test/jdk/java/lang/ProcessHandle/PermissionTest.java line 215:
213: permissions.add(new PropertyPermission("testng.report.xml.name", "read")); 214: permissions.add(new ReflectPermission("suppressAccessChecks")); 215: permissions.add(new PropertyPermission("testng.timezone", "read"));
might be better to group the testng.* properties so they aren't mixed up with the other runtime permissions. ------------- PR: https://git.openjdk.java.net/jdk/pull/3471
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: TestNG updates Permission re-organization ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3471/files - new: https://git.openjdk.java.net/jdk/pull/3471/files/0183f88b..20ef2bd0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3471&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3471&range=00-01 Stats: 20 lines in 2 files changed: 10 ins; 10 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3471.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3471/head:pull/3471 PR: https://git.openjdk.java.net/jdk/pull/3471
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen <lancea@openjdk.org> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
TestNG updates Permission re-organization
Looks good. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3471
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen <lancea@openjdk.org> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
TestNG updates Permission re-organization
Marked as reviewed by bpb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3471
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen <lancea@openjdk.org> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
TestNG updates Permission re-organization
Marked as reviewed by alanb (Reviewer). test/jdk/java/sql/testng/util/TestPolicy.java line 27:
25: import java.io.FilePermission; 26: import java.lang.reflect.ReflectPermission; 27: import java.security.*;
My guess is that you didn't mean the change the import. ------------- PR: https://git.openjdk.java.net/jdk/pull/3471
On Apr 14, 2021, at 2:13 AM, Alan Bateman <alanb@openjdk.java.net<mailto:alanb@openjdk.java.net>> wrote: On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen <lancea@openjdk.org<mailto:lancea@openjdk.org>> wrote: Hi all, Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG. Best, Lance Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: TestNG updates Permission re-organization Marked as reviewed by alanb (Reviewer). test/jdk/java/sql/testng/util/TestPolicy.java line 27: 25: import java.io.FilePermission; 26: import java.lang.reflect.ReflectPermission; 27: import java.security.*; My guess is that you didn't mean the change the import. Intellij did that automagically. I just reverted the change for consistency ------------- PR: https://git.openjdk.java.net/jdk/pull/3471 [cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home] Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com<mailto:Lance.Andersen@oracle.com>
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Add back individual security imports ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3471/files - new: https://git.openjdk.java.net/jdk/pull/3471/files/20ef2bd0..31edda8e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3471&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3471&range=01-02 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/3471.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3471/head:pull/3471 PR: https://git.openjdk.java.net/jdk/pull/3471
On Tue, 13 Apr 2021 18:01:49 GMT, Lance Andersen <lancea@openjdk.org> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.
Best, Lance
This pull request has now been integrated. Changeset: ffb37718 Author: Lance Andersen <lancea@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/ffb37718 Stats: 22 lines in 2 files changed: 16 ins; 4 del; 2 mod 8265019: Update tests for additional TestNG test permissions Reviewed-by: naoto, bpb, alanb ------------- PR: https://git.openjdk.java.net/jdk/pull/3471
participants (5)
-
Alan Bateman
-
Brian Burkhalter
-
Lance Andersen
-
Lance Andersen
-
Naoto Sato