Hi Matthias, I have reviewed your change, +1 I also reviewed the CSR. Best regards Christoph

-----Original Message----- From: Baesken, Matthias Sent: Mittwoch, 5. September 2018 10:07 To: security-dev@openjdk.java.net; Weijun Wang <weijun.wang@oracle.com>; core-libs-dev@openjdk.java.net Cc: Langer, Christoph <christoph.langer@sap.com> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Hi Max, thanks for adding yourself as a reviewer.

I set the CSR ( https://bugs.openjdk.java.net/browse/JDK-8207768 ) to proposed.

Best regards, Matthias

...

Message: 2 Date: Tue, 4 Sep 2018 21:31:58 +0800 From: Weijun Wang <weijun.wang@oracle.com> To: "Baesken, Matthias" <matthias.baesken@sap.com> Cc: "security-dev@openjdk.java.net" <security-dev@openjdk.java.net>, "core-libs-dev@openjdk.java.net" <core-libs- dev@openjdk.java.net> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives Message-ID: <058BD7B5-4D3A-4B56-ACB0-0DEDDDEA24B3@oracle.com> Content-Type: text/plain; charset=us-ascii

I've added myself as a reviewer. You might want to set scope to "JDK".

A CSR is approved by the CSR group after you finalize it. First you should propose it. If you think it's urgent or trivial, you can also fast-track it.

Read https://wiki.openjdk.java.net/display/csr/Main for more details.

Thanks Max

...

On Sep 4, 2018, at 7:33 PM, Baesken, Matthias <matthias.baesken@sap.com> wrote:

...

The change looks fine. We can enhance the name if we want to support .SF parsing later.

Please revise your CSR and get it approved first.

Hi Max, Thanks !

I adjusted the CSR , please approve :

https://bugs.openjdk.java.net/browse/JDK-8207768

Best regards, Matthias