RFR: 8273435: Remove redundant zero-length check in ClassDesc.of
After [JDK-8215510](https://bugs.openjdk.java.net/browse/JDK-8215510) (eed3a536c0) this condition is always `false`. Empty package name is handled separately. Found by IntelliJ inspection. ------------- Commit messages: - [PATCH] Remove redundant zero-length check in ClassDesc.of Changes: https://git.openjdk.java.net/jdk/pull/5157/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5157&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273435 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5157.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5157/head:pull/5157 PR: https://git.openjdk.java.net/jdk/pull/5157
On Wed, 18 Aug 2021 07:28:57 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
After [JDK-8215510](https://bugs.openjdk.java.net/browse/JDK-8215510) (eed3a536c0) this condition is always `false`. Empty package name is handled separately. Found by IntelliJ inspection.
Marked as reviewed by stsypanov@github.com (no known OpenJDK username). Hi @turbanoff the change looks good and reasonable, I've filed an issue for this: https://bugs.openjdk.java.net/browse/JDK-8273435, so you can integrate now ------------- PR: https://git.openjdk.java.net/jdk/pull/5157
On Wed, 18 Aug 2021 07:28:57 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
After [JDK-8215510](https://bugs.openjdk.java.net/browse/JDK-8215510) (eed3a536c0) this condition is always `false`. Empty package name is handled separately. Found by IntelliJ inspection.
Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/5157
On Wed, 18 Aug 2021 07:28:57 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
After [JDK-8215510](https://bugs.openjdk.java.net/browse/JDK-8215510) (eed3a536c0) this condition is always `false`. Empty package name is handled separately. Found by IntelliJ inspection.
Can someone sponsor changes, please? ------------- PR: https://git.openjdk.java.net/jdk/pull/5157
On Wed, 18 Aug 2021 07:28:57 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
After [JDK-8215510](https://bugs.openjdk.java.net/browse/JDK-8215510) (eed3a536c0) this condition is always `false`. Empty package name is handled separately. Found by IntelliJ inspection.
This pull request has now been integrated. Changeset: 355356c4 Author: Andrey Turbanov <turbanoff@gmail.com> Committer: Naoto Sato <naoto@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/355356c405adb9287b786b0b045c2eb974d2... Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8273435: Remove redundant zero-length check in ClassDesc.of Reviewed-by: rriggs ------------- PR: https://git.openjdk.java.net/jdk/pull/5157
participants (3)
-
Andrey Turbanov
-
Roger Riggs
-
Сергей Цыпанов