RFR: 8263855: Use the blessed modifier order in java.management/naming
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules. ------------- Commit messages: - Use the blessed modifier order in java.management/naming Changes: https://git.openjdk.java.net/jdk/pull/3078/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3078&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263855 Stats: 158 lines in 39 files changed: 0 ins; 0 del; 158 mod Patch: https://git.openjdk.java.net/jdk/pull/3078.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3078/head:pull/3078 PR: https://git.openjdk.java.net/jdk/pull/3078
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Would someone mind creating a bug for me? In addition, if it would help, we could create a parent bug for applying cleanups and associate #2993 and #2991. ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Would someone mind creating a bug for me? In addition, if it would help, we could create a parent bug for applying cleanups and associate #2993 and #2991.
@cl4es would you mind creating a parent task of something like "Source code cleanups" and then another sub task for this change please? ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 10:20:39 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Would someone mind creating a bug for me? In addition, if it would help, we could create a parent bug for applying cleanups and associate #2993 and #2991.
@cl4es would you mind creating a parent task of something like "Source code cleanups" and then another sub task for this change please?
Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this along with an umbrella RFE. ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad <redestad@openjdk.org> wrote:
@cl4es would you mind creating a parent task of something like "Source code cleanups" and then another sub task for this change please?
Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this along with an umbrella RFE.
Thanks @cl4es -- do I need to update the git commit message as well, or is updating the title of the PR sufficient? I recall you suggesting not to do amend/rebases previously. ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 13:08:24 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this along with an umbrella RFE.
Thanks @cl4es -- do I need to update the git commit message as well, or is updating the title of the PR sufficient? I recall you suggesting not to do amend/rebases previously.
No, the git commit messages here doesn't matter, the bots will use the PR name when merging into master. It's good form to use reasonably consistent commit messages as you add commits to a PR, but altering commit history is not necessary and might even be disruptive once a PR has been opened. There's the /summary command you could use to add additional comments to the final commit, see https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullReques... ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad <redestad@openjdk.org> wrote:
Thanks @cl4es -- do I need to update the git commit message as well, or is updating the title of the PR sufficient? I recall you suggesting not to do amend/rebases previously.
No, the git commit messages here doesn't matter, the bots will use the PR name when merging into master. It's good form to use reasonably consistent commit messages as you add commits to a PR, but altering commit history is not necessary and might even be disruptive once a PR has been opened.
There's the /summary command you could use to add additional comments to the final commit, see https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullReques...
Thanks @cl4es will adjust my submissions appropriately in the future. ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Overall good - found a few cases where the private modifier is in the wrong place that ought to be fixed as well. src/java.naming/share/classes/com/sun/jndi/ldap/EventQueue.java line 48:
46: */ 47: final class EventQueue implements Runnable { 48: static final private boolean debug = false;
Move private to the front? src/java.naming/share/classes/com/sun/jndi/ldap/EventSupport.java line 116:
114: */ 115: final class EventSupport { 116: static final private boolean debug = false;
Move private to the front? src/java.naming/share/classes/com/sun/jndi/ldap/LdapSchemaCtx.java line 389:
387: } 388: 389: static final private class SchemaInfo {
Move private to the front? ------------- Changes requested by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3078
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision: Added more replacements of 'final public' with 'public final' ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3078/files - new: https://git.openjdk.java.net/jdk/pull/3078/files/f1bc7269..1c900d2d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3078&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3078&range=00-01 Stats: 106 lines in 37 files changed: 0 ins; 0 del; 106 mod Patch: https://git.openjdk.java.net/jdk/pull/3078.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3078/head:pull/3078 PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
Added more replacements of 'final public' with 'public final'
Marked as reviewed by redestad (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
Added more replacements of 'final public' with 'public final'
`java.naming` module changes look good to me. ------------- Marked as reviewed by aefimov (Committer). PR: https://git.openjdk.java.net/jdk/pull/3078
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
Added more replacements of 'final public' with 'public final'
Marked as reviewed by dfuchs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules.
This pull request has now been integrated. Changeset: 5262d95b Author: Alex Blewitt <alex.blewitt@gmail.com> Committer: Claes Redestad <redestad@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/5262d95b Stats: 261 lines in 69 files changed: 0 ins; 0 del; 261 mod 8263855: Use the blessed modifier order in java.management/naming Reviewed-by: redestad, aefimov, dfuchs ------------- PR: https://git.openjdk.java.net/jdk/pull/3078
participants (4)
-
Aleksei Efimov
-
Alex Blewitt
-
Claes Redestad
-
Daniel Fuchs