Re: RFR (S) 8057936: java.net.URLClassLoader.findClass uses exceptions in control flow
On 09/10/2014 04:38 PM, mark.reinhold@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/ Looks fine, but when an exception declaration is on its own line then the opening brace of the method should be on its own line too, as in the original:
protected Class<?> findClass(final String name) throws ClassNotFoundException {
Original had weird 5 space indentation though: http://cr.openjdk.java.net/~redestad/8057936/webrev.6/ Will need a sponsor for this, if it looks good to everyone. /Claes
- Mark
On 10/09/14 16:04, Claes Redestad wrote:
On 09/10/2014 04:38 PM, mark.reinhold@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/ Looks fine, but when an exception declaration is on its own line then the opening brace of the method should be on its own line too, as in the original:
protected Class<?> findClass(final String name) throws ClassNotFoundException {
Original had weird 5 space indentation though:
http://cr.openjdk.java.net/~redestad/8057936/webrev.6/
Will need a sponsor for this, if it looks good to everyone.
/Claes
I'll sponsor that for you. Michael
- Mark
On 10/09/2014 16:04, Claes Redestad wrote:
Original had weird 5 space indentation though:
http://cr.openjdk.java.net/~redestad/8057936/webrev.6/
Will need a sponsor for this, if it looks good to everyone.
Michael's suggestion was good, it much simpler now. -Alan.
On 9/10/2014 8:04 AM, Claes Redestad wrote:
Looks good. A simple change gives 4-12% gains from your microbenchmark - pretty good. Mandy
On 10 Sep 2014, at 16:04, Claes Redestad <claes.redestad@oracle.com> wrote:
On 09/10/2014 04:38 PM, mark.reinhold@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/ Looks fine, but when an exception declaration is on its own line then the opening brace of the method should be on its own line too, as in the original:
protected Class<?> findClass(final String name) throws ClassNotFoundException {
Original had weird 5 space indentation though:
This latest version looks good. -Chris.
Will need a sponsor for this, if it looks good to everyone.
/Claes
- Mark
On 11/09/2014 09:43, Chris Hegarty wrote:
On 10 Sep 2014, at 16:04, Claes Redestad <claes.redestad@oracle.com> wrote:
On 09/10/2014 04:38 PM, mark.reinhold@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/ Looks fine, but when an exception declaration is on its own line then the opening brace of the method should be on its own line too, as in the original:
protected Class<?> findClass(final String name) throws ClassNotFoundException { Original had weird 5 space indentation though:
http://cr.openjdk.java.net/~redestad/8057936/webrev.6/ This latest version looks good.
I agree and much more readable since the API adjustment. -Alan
On 11/09/2014 10:16, Alan Bateman wrote:
I agree and much more readable since the API adjustment.
Ignoring that comment for this thread, my comment was on the parseInt changes in your other java.net patch which are looking much better now. -Alan
participants (5)
-
Alan Bateman
-
Chris Hegarty
-
Claes Redestad
-
Mandy Chung
-
Michael McMahon