RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a
Hello All, Please review the patch for tzdata2020a integration into jdk. Release details can be found here: http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8243541 The patch has passed all the related testing including JCK and uses vanguard format tzdata. Thanks, Kiran
Hi Kiran, Thanks for working on this update so promptly. The innocent renaming of America/Godthab to America/Nuuk is causing much trouble. Since it's a renaming, both names remain and I expected them to have the same metadata. So I expected the entries in TimeZoneNames.java and the translations in e.g.TimeZoneNames_de.java to have parallel entries for both names. Which is what happened with Asia/Rangoon rename to Asia/Yangon. Consider the output of $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)' (I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't) (I help keep Google's java programs up to date with tzdata) On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar < kiran.sidhartha.ravikumar@oracle.com> wrote:
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8243541
The patch has passed all the related testing including JCK and uses vanguard format tzdata.
Thanks,
Kiran
Hi Martin and Andrew, Thanks for the review and providing a direction towards updating the translations. Here is an updated webrev with the changes: http://cr.openjdk.java.net/~kravikumar/8243541/webrev/ All associated tests pass. Please let me know if they look alright. Thanks, Kiran On 27/04/2020 15:16, Martin Buchholz wrote:
Hi Kiran,
Thanks for working on this update so promptly.
The innocent renaming of America/Godthab to America/Nuuk is causing much trouble. Since it's a renaming, both names remain and I expected them to have the same metadata. So I expected the entries in TimeZoneNames.java and the translations in e.g.TimeZoneNames_de.java to have parallel entries for both names. Which is what happened with Asia/Rangoon rename to Asia/Yangon. Consider the output of $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)'
(I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't)
(I help keep Google's java programs up to date with tzdata)
On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar <kiran.sidhartha.ravikumar@oracle.com <mailto:kiran.sidhartha.ravikumar@oracle.com>> wrote:
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html <https://urldefense.com/v3/__http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html__;!!GqivPVa7Brio!PGqR3RfBtyodUFrLtWqpA28agMmn_GtHHtKh8oegq3ePykB5KcxVpzelGnZjTxeLKvzw6K2xqoo$>
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8243541
The patch has passed all the related testing including JCK and uses vanguard format tzdata.
Thanks,
Kiran
Thanks. This looks good. How the tzdata updates get done has always been a mystery to me. If you've written any helper scripts or process docs, checking those in as well (but which directory?) might be useful. (I maintain such things at Google, but they are not very useful for you - too full of Googleisms.) On Mon, Apr 27, 2020 at 11:19 AM Kiran Ravikumar <kiran.sidhartha.ravikumar@oracle.com> wrote:
Hi Martin and Andrew,
Thanks for the review and providing a direction towards updating the translations.
Here is an updated webrev with the changes:
http://cr.openjdk.java.net/~kravikumar/8243541/webrev/
All associated tests pass. Please let me know if they look alright.
Thanks,
Kiran
On 27/04/2020 15:16, Martin Buchholz wrote:
Hi Kiran,
Thanks for working on this update so promptly.
The innocent renaming of America/Godthab to America/Nuuk is causing much trouble. Since it's a renaming, both names remain and I expected them to have the same metadata. So I expected the entries in TimeZoneNames.java and the translations in e.g.TimeZoneNames_de.java to have parallel entries for both names. Which is what happened with Asia/Rangoon rename to Asia/Yangon. Consider the output of $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)'
(I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't)
(I help keep Google's java programs up to date with tzdata)
On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar <kiran.sidhartha.ravikumar@oracle.com> wrote:
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8243541
The patch has passed all the related testing including JCK and uses vanguard format tzdata.
Thanks,
Kiran
Looks OK to me. Thanks for the update. Naoto On 4/27/20 11:19 AM, Kiran Ravikumar wrote:
Hi Martin and Andrew,
Thanks for the review and providing a direction towards updating the translations.
Here is an updated webrev with the changes:
http://cr.openjdk.java.net/~kravikumar/8243541/webrev/
All associated tests pass. Please let me know if they look alright.
Thanks,
Kiran
On 27/04/2020 15:16, Martin Buchholz wrote:
Hi Kiran,
Thanks for working on this update so promptly.
The innocent renaming of America/Godthab to America/Nuuk is causing much trouble. Since it's a renaming, both names remain and I expected them to have the same metadata. So I expected the entries in TimeZoneNames.java and the translations in e.g.TimeZoneNames_de.java to have parallel entries for both names. Which is what happened with Asia/Rangoon rename to Asia/Yangon. Consider the output of $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)'
(I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't)
(I help keep Google's java programs up to date with tzdata)
On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar <kiran.sidhartha.ravikumar@oracle.com <mailto:kiran.sidhartha.ravikumar@oracle.com>> wrote:
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8243541
The patch has passed all the related testing including JCK and uses vanguard format tzdata.
Thanks,
Kiran
On 27/04/2020 19:19, Kiran Ravikumar wrote:
Hi Martin and Andrew,
Thanks for the review and providing a direction towards updating the translations.
Here is an updated webrev with the changes:
http://cr.openjdk.java.net/~kravikumar/8243541/webrev/
All associated tests pass. Please let me know if they look alright.
Thanks,
Kiran
Looks good to me. Now we have a translation for Nuuk in all the languages for which we had Godthab translations, and the zones are tested too. Thumbs up from me! Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
On 27/04/2020 12:13, Kiran Ravikumar wrote:
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8243541
The patch has passed all the related testing including JCK and uses vanguard format tzdata.
Thanks,
Kiran
First of all, I'd like to concur with Martin in thanking you for working on this so quickly. The new zone got flagged as our system tzdata update was being prepared and I was able to already find a bug filed for tzdata2020a. I was about to e-mail you to ask your progress on it, then thought to check the mailing list first. I was happily surprised to find the patch already written and posted for review! :-) The changes look fine to me. It would be good to get the translations in for America/Nuuk, but, for the time being, at least we have the fallback case so the JDK doesn't crash if asked to print that timezone. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
participants (4)
-
Andrew John Hughes
-
Kiran Ravikumar
-
Martin Buchholz
-
naoto.sato@oracle.com