RFR: 8205184: Delegating Iterator implementations that don't delegate forEachRemaining()
8205184: Delegating Iterator implementations that don't delegate forEachRemaining() http://cr.openjdk.java.net/~martin/webrevs/jdk/delegate-forEachRemaining/ https://bugs.openjdk.java.net/browse/JDK-8205184
Looks good. Sometimes in these cases i reach for proxy rather than explicit code. It tends to be more robust to certain changes at the expense of reflective complexity. You could probably reduce the test method names by removing the “forEachRemainingIsDelegated_” given that can be inferred from the class name. Paul.
On Jun 21, 2018, at 8:06 PM, Martin Buchholz <martinrb@google.com> wrote:
8205184: Delegating Iterator implementations that don't delegate forEachRemaining() http://cr.openjdk.java.net/~martin/webrevs/jdk/delegate-forEachRemaining/ https://bugs.openjdk.java.net/browse/JDK-8205184
On Mon, Jun 25, 2018 at 11:17 AM, Paul Sandoz <paul.sandoz@oracle.com> wrote:
Looks good. Sometimes in these cases i reach for proxy rather than explicit code. It tends to be more robust to certain changes at the expense of reflective complexity.
Hmmm ... Never done that in a test before.
You could probably reduce the test method names by removing the “forEachRemainingIsDelegated_” given that can be inferred from the class name.
test method names shortened.
Committed.
participants (2)
-
Martin Buchholz
-
Paul Sandoz