RFR: 8129601: [launcher] test VersionCheck.java fails with new version string (more removal of dead code)
Hi, Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need not be passed around in the build system. Thanks Kumar Bug: https://bugs.openjdk.java.net/browse/JDK-8129601, Webrev: http://cr.openjdk.java.net/~ksrini/8129601/
On 26/06/2015 15:20, Kumar Srinivasan wrote:
Hi,
Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need not be passed around in the build system. Is it necessary to keep the dotversion parameter on JLI_Launch? Otherwise looks okay to me.
-Alan
On 6/26/2015 7:31 AM, Alan Bateman wrote:
On 26/06/2015 15:20, Kumar Srinivasan wrote:
Hi,
Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need not be passed around in the build system. Is it necessary to keep the dotversion parameter on JLI_Launch? Otherwise looks okay to me.
Unfortunately yes, we have to keep this for backwards compatibility it is used by other client internal tools. Kumar
-Alan
Looks fine Kumar; cheers, -Joe On 6/26/2015 7:20 AM, Kumar Srinivasan wrote:
Hi,
Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need not be passed around in the build system.
Thanks Kumar
Bug: https://bugs.openjdk.java.net/browse/JDK-8129601, Webrev: http://cr.openjdk.java.net/~ksrini/8129601/
participants (3)
-
Alan Bateman
-
Joseph D. Darcy
-
Kumar Srinivasan