[10] RFR 6354947: [Fmt-*] DecimalFormat ignores FieldPosition settings on input, contrary to Javadocs
Hi, Please review the fix for JDK-6354947 Bug: https://bugs.openjdk.java.net/browse/JDK-6354947 Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191014 Fix: Clarified handling of the FieldPosition settings in the java.text.Format APIs specification. Regards, Nishit Jain
+1 Naoto On 11/16/17 10:52 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-6354947
Bug: https://bugs.openjdk.java.net/browse/JDK-6354947 Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
Fix: Clarified handling of the FieldPosition settings in the java.text.Format APIs specification.
Regards, Nishit Jain
Hi Nishit, The webrev and updates to the javadoc look fine. However, the summary of the issue does not reflect the issue and implies the implementation is wrong; but it is the javadoc that need clarification. Please change the issue summary (on both the CSR and the issue) to reflect the true cause, something like: [Fmt-*] Clarify DecimalFormat description of FieldPosition use Thanks, Roger On 11/17/2017 7:21 PM, Naoto Sato wrote:
+1
Naoto
On 11/16/17 10:52 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-6354947
Bug: https://bugs.openjdk.java.net/browse/JDK-6354947 Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
Fix: Clarified handling of the FieldPosition settings in the java.text.Format APIs specification.
Regards, Nishit Jain
Thanks Naoto, Roger for the review.
the summary of the issue does not reflect the issue and implies the implementation is wrong; but it is the javadoc that need clarification. It is probably because when this bug was filed, it was not clear whether implementation will be changed as per javadoc or the javadoc will be changed.
Please change the issue summary (on both the CSR and the issue) to reflect the true cause. Done
Regards, Nishit Jain On 29-11-2017 20:35, Roger Riggs wrote:
Hi Nishit,
The webrev and updates to the javadoc look fine.
However, the summary of the issue does not reflect the issue and implies the implementation is wrong; but it is the javadoc that need clarification.
Please change the issue summary (on both the CSR and the issue) to reflect the true cause, something like:
[Fmt-*] Clarify DecimalFormat description of FieldPosition use
Thanks, Roger
On 11/17/2017 7:21 PM, Naoto Sato wrote:
+1
Naoto
On 11/16/17 10:52 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-6354947
Bug: https://bugs.openjdk.java.net/browse/JDK-6354947 Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
Fix: Clarified handling of the FieldPosition settings in the java.text.Format APIs specification.
Regards, Nishit Jain
participants (3)
-
Naoto Sato
-
Nishit Jain
-
Roger Riggs