Thank you Sherman for reviewing the webrev and approving the changes. Can you please create a bug to proceed further. Regarding the other two charsets, IBM964 and IBM33722, we will analyze further to see whether it can be better implemented. Regards, Nasser Ebrahim From: Xueming Shen <xueming.shen@oracle.com> To: core-libs-dev@openjdk.java.net Date: 07/26/2018 10:36 PM Subject: Re: Add x-IBM-1129 charset Sent by: "core-libs-dev" <core-libs-dev-bounces@openjdk.java.net> The change looks fine. Btw, do you guy have better implementation for these two charsets? These two were left untouched when I did the reimplementation back to 6/7. Did not have time to figure out its mapping table (especially the compatibility concern when dealing with the mapping hard-coded inside the source and those maps from cdc repository). This was the main reason I did not move the SimpleEUCEncoder into the sun.nio.cs.DoubleByte.java. -Sherman On 5/19/18, 12:56 AM, Nasser Ebrahim wrote:

Hello,

With the following three bugs, all the default locale charsets except two (Vi_VN.IBM-1129& ja_JP.IBM-eucJP) are fixed for AIX platform.

- JDK-8201540: [AIX] Extend the set of supported charsets in java.base - JDK-8202329: Codepage mappings for IBM-943 and Big5 (aix) -

http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053050.html

: [AIX] Add charset IBM-964 (default charset for zh_TW.IBM-eucTW) to stdcs [bug not yet opened].

For those fixed charsets, the charsets were existing in the extended charsets (jdk.charsets) and they were not working with default locale charset as it did not exist in the standard charset (java.base). The charsets correspond to the two pending locale (Vi_VN.IBM-1129& ja_JP.IBM-eucJP) does not exist in the jdk. They need to be added to the extended charsets before adding to stdcs on AIX platform.

Here, am including the patch to fix the charset IBM-1129 for the locale Vi_VN.IBM-1129. We are working on the other missing charset (for ja_JP.IBM-eucJP) which will be contributed in some time.

The webrev of the fix is available at

http://cr.openjdk.java.net/~aleonard/IBM1129/webrev.00/

Kindly request you to open a bug and review the fix. Please let me know

if

you have any questions.

Thank you, Nasser Ebrahim

I've created JDK-8208634 [1] for x-IBM-1129 and will reply soon on the other thread (as I think we do need infrastructure in the build to make it easy to included/exclude charsets rather than having them be included

automatically on all builds).

Thank you Alan for opening the bug for this issue. I will wait for your response on the other thread and proceed as per your inputs. Regards, Nasser Ebrahim From: Alan Bateman <Alan.Bateman@oracle.com> To: Nasser Ebrahim <enasser@in.ibm.com>, Xueming Shen <xueming.shen@oracle.com>, core-libs-dev@openjdk.java.net Date: 08/01/2018 05:45 PM Subject: Re: Add x-IBM-1129 charset On 30/07/2018 08:47, Nasser Ebrahim wrote:

Thank you Sherman for reviewing the webrev and approving the changes. Can you please create a bug to proceed further.

Regarding the other two charsets, IBM964 and IBM33722, we will analyze further to see whether it can be better implemented.

I've created JDK-8208634 [1] for x-IBM-1129 and will reply soon on the other thread (as I think we do need infrastructure in the build to make it easy to included/exclude charsets rather than having them be included automatically on all builds). -Alan [1] https://bugs.openjdk.java.net/browse/JDK-8208634