RFR: JDK-8218186 Clean up CLDR generation in build
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project. This patch aims to resolving most of this. The CLDRConverter build tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, for their respective module. The calls have been updated to match modern build-infra standards. Also, the raw CLDR data was located mixed in with the Java source, in jdk.localedata. This patch also moves the data to make/data/cldr, to align with input data to all other build tools. Bug: https://bugs.openjdk.java.net/browse/JDK-8218186 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01 /Magnus
Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Naoto On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project.
This patch aims to resolving most of this. The CLDRConverter build tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, for their respective module. The calls have been updated to match modern build-infra standards.
Also, the raw CLDR data was located mixed in with the Java source, in jdk.localedata. This patch also moves the data to make/data/cldr, to align with input data to all other build tools.
Bug: https://bugs.openjdk.java.net/browse/JDK-8218186 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01
/Magnus
On 2019-02-01 14:43, naoto.sato@oracle.com wrote:
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same as before this fix, correct?
Yes. I have verified this using the COMPARE_BUILD functionality. /Magnus
Naoto
On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project.
This patch aims to resolving most of this. The CLDRConverter build tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, for their respective module. The calls have been updated to match modern build-infra standards.
Also, the raw CLDR data was located mixed in with the Java source, in jdk.localedata. This patch also moves the data to make/data/cldr, to align with input data to all other build tools.
Bug: https://bugs.openjdk.java.net/browse/JDK-8218186 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01
/Magnus
Thanks, Magnus. The change looks good to me too. Naoto On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote:
On 2019-02-01 14:43, naoto.sato@oracle.com wrote:
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same as before this fix, correct?
Yes. I have verified this using the COMPARE_BUILD functionality.
/Magnus
Naoto
On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project.
This patch aims to resolving most of this. The CLDRConverter build tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, for their respective module. The calls have been updated to match modern build-infra standards.
Also, the raw CLDR data was located mixed in with the Java source, in jdk.localedata. This patch also moves the data to make/data/cldr, to align with input data to all other build tools.
Bug: https://bugs.openjdk.java.net/browse/JDK-8218186 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01
/Magnus
Looks good. /Erik On 2019-02-01 02:50, Magnus Ihse Bursie wrote:
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project.
This patch aims to resolving most of this. The CLDRConverter build tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, for their respective module. The calls have been updated to match modern build-infra standards.
Also, the raw CLDR data was located mixed in with the Java source, in jdk.localedata. This patch also moves the data to make/data/cldr, to align with input data to all other build tools.
Bug: https://bugs.openjdk.java.net/browse/JDK-8218186 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01
/Magnus
participants (4)
-
Erik Joelsson
-
Magnus Ihse Bursie
-
Naoto Sato
-
naoto.sato＠oracle.com