Hi Fernando, Thanks for the update. Here's the updated webrev. The previous webrev was moved to webrev01. http://cr.openjdk.java.net/~joehw/jdk15/8183266/webrev02/ This change looks good to me. Best, Joe On 4/29/2020 9:38 AM, Joe Wang wrote:

Hi Fernando,

Thanks for adding coverage to this API. The change looks good overall. A couple of comments to the test:

Line 39 instead of LocalPart, it may be better to verify the QName themselves, I mean, assert the QNames are equal.

Line 19-21: the comment block can be moved to a @summary tag with a message sth. like "Verifies the specification of the XPathEvaluationResult API" to allow potential future additions.

Best,

Joe

On 4/29/2020 4:50 AM, Fernando Guallini wrote:

...

Hi all,

Please, review the following change:

webrev: http://cr.openjdk.java.net/~joehw/jdk15/8183266/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8183266

Change details: - Added test coverage for XPathEvaluationResult.XPathResultType.getQNameType method - Added type check for the getQNameType flow restricting the Number class subtypes to satisfy the spec (Integer, Double and Long) - Updated equalsClassType method to be null safe.

Kind regards, Fernando