RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources. [1] https://bugs.openjdk.java.net/browse/JDK-8191709 [2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/ Thanks, Alexander
The comparison isn't quite right. It will fail if either the major or minor is less than the minimum. This means, for example, that 4.1 will be considered less than 3.6. -- Kevin On 2/26/2019 3:25 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
- Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources.
[1] https://bugs.openjdk.java.net/browse/JDK-8191709
[2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/
Thanks, Alexander
Hi Kevin, You right, comparison was not right. I fixed it. http://cr.openjdk.java.net/~almatvee/8191709/webrev.01/ Thanks, Alexander On 2/26/2019 4:17 PM, Kevin Rushforth wrote:
The comparison isn't quite right. It will fail if either the major or minor is less than the minimum. This means, for example, that 4.1 will be considered less than 3.6.
-- Kevin
On 2/26/2019 3:25 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
- Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources.
[1] https://bugs.openjdk.java.net/browse/JDK-8191709
[2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/
Thanks, Alexander
looks good now. /Andy On 2/27/2019 7:24 PM, Alexander Matveev wrote:
Hi Kevin,
You right, comparison was not right. I fixed it. http://cr.openjdk.java.net/~almatvee/8191709/webrev.01/
Thanks, Alexander
On 2/26/2019 4:17 PM, Kevin Rushforth wrote:
The comparison isn't quite right. It will fail if either the major or minor is less than the minimum. This means, for example, that 4.1 will be considered less than 3.6.
-- Kevin
On 2/26/2019 3:25 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
- Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources.
[1] https://bugs.openjdk.java.net/browse/JDK-8191709
[2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/
Thanks, Alexander
That looks better. Btw, the copyright header should only have a single "2019" (we don't repeat the year for a file created and last modified in the same year). You can fix this when you push. Thanks. -- Kevin On 2/27/2019 4:24 PM, Alexander Matveev wrote:
Hi Kevin,
You right, comparison was not right. I fixed it. http://cr.openjdk.java.net/~almatvee/8191709/webrev.01/
Thanks, Alexander
On 2/26/2019 4:17 PM, Kevin Rushforth wrote:
The comparison isn't quite right. It will fail if either the major or minor is less than the minimum. This means, for example, that 4.1 will be considered less than 3.6.
-- Kevin
On 2/26/2019 3:25 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
- Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources.
[1] https://bugs.openjdk.java.net/browse/JDK-8191709
[2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/
Thanks, Alexander
participants (3)
-
Alexander Matveev
-
Andy Herrick
-
Kevin Rushforth