Review request for JDK-8151065 : Typo in javax.naming.CompoundName
Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065 Bug - Typo in javax.naming.CompoundName Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/ I have just rectified and modified those error. And moving forward it for review. Regards, Abhijit
Hi Abhijit, Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states "Affects Version/s: 8u74" and the patch is prepared against JDK 9 as far as I can see.
On 11 Mar 2016, at 08:16, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi all,
Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065
Bug - Typo in javax.naming.CompoundName
Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/
I have just rectified and modified those error. And moving forward it for review.
Regards,
Abhijit
Hi Pavel, As of now I'm going to update in 9ea. But if you are suggesting me to update in 8 as well, I can do that definitely. So, please let me know your suggestion. Thank you. Kind regards, Abhijit -----Original Message----- From: Pavel Rappo Sent: Friday, March 11, 2016 2:40 PM To: Abhijit Roy Cc: core-libs-dev; Vincent Ryan Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName Hi Abhijit, Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states "Affects Version/s: 8u74" and the patch is prepared against JDK 9 as far as I can see.
On 11 Mar 2016, at 08:16, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi all,
Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065
Bug - Typo in javax.naming.CompoundName
Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/
I have just rectified and modified those error. And moving forward it for review.
Regards,
Abhijit
Given the level of severity I assume process overhead would be way too big. So it's totally up to you.
On 11 Mar 2016, at 11:33, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi Pavel,
As of now I'm going to update in 9ea. But if you are suggesting me to update in 8 as well, I can do that definitely. So, please let me know your suggestion.
Thank you.
Kind regards, Abhijit
-----Original Message----- From: Pavel Rappo Sent: Friday, March 11, 2016 2:40 PM To: Abhijit Roy Cc: core-libs-dev; Vincent Ryan Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName
Hi Abhijit,
Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states "Affects Version/s: 8u74" and the patch is prepared against JDK 9 as far as I can see.
On 11 Mar 2016, at 08:16, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi all,
Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065
Bug - Typo in javax.naming.CompoundName
Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/
I have just rectified and modified those error. And moving forward it for review.
Regards,
Abhijit
Your fix looks fine to me. Thanks. Pavel has offered to sponsor this change for you.
On 11 Mar 2016, at 11:33, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi Pavel,
As of now I'm going to update in 9ea. But if you are suggesting me to update in 8 as well, I can do that definitely. So, please let me know your suggestion.
Thank you.
Kind regards, Abhijit
-----Original Message----- From: Pavel Rappo Sent: Friday, March 11, 2016 2:40 PM To: Abhijit Roy Cc: core-libs-dev; Vincent Ryan Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName
Hi Abhijit,
Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states "Affects Version/s: 8u74" and the patch is prepared against JDK 9 as far as I can see.
On 11 Mar 2016, at 08:16, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi all,
Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065
Bug - Typo in javax.naming.CompoundName
Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/
I have just rectified and modified those error. And moving forward it for review.
Regards,
Abhijit
Hi Vincent, It'll be great if Pavel can do this for me. Thanks Abhijit -----Original Message----- From: Vincent Ryan Sent: Friday, March 11, 2016 5:14 PM To: Abhijit Roy Cc: Pavel Rappo; core-libs-dev Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName Your fix looks fine to me. Thanks. Pavel has offered to sponsor this change for you.
On 11 Mar 2016, at 11:33, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi Pavel,
As of now I'm going to update in 9ea. But if you are suggesting me to update in 8 as well, I can do that definitely. So, please let me know your suggestion.
Thank you.
Kind regards, Abhijit
-----Original Message----- From: Pavel Rappo Sent: Friday, March 11, 2016 2:40 PM To: Abhijit Roy Cc: core-libs-dev; Vincent Ryan Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName
Hi Abhijit,
Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states "Affects Version/s: 8u74" and the patch is prepared against JDK 9 as far as I can see.
On 11 Mar 2016, at 08:16, Abhijit Roy <abhijit.r.roy@oracle.com> wrote:
Hi all,
Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065
Bug - Typo in javax.naming.CompoundName
Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/
I have just rectified and modified those error. And moving forward it for review.
Regards,
Abhijit
participants (3)
-
Abhijit Roy
-
Pavel Rappo
-
Vincent Ryan