Hi, Please review the changes for ISO 4217 Amendment #168 #169. Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169 Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for consistent. Changes include: - Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 minor 2 - Update the currency name to 'Bolívar Soberano' - Move the currency VEF to historical currencies - Correct the currency name for PHILIPPINES (THE): Philippine Peso (instead of Piso) - Change the country name: SWAZILAND to ESWATINI Webrev: http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/ Build and test passed on mach5 for all platforms. Thanks, Leo
Hi Leo, Looks good to me. Also, please work with sustaining wrt backports. Naoto On 8/28/18 7:56 AM, li.jiang@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169
Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for consistent.
Changes include:
- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 minor 2 - Update the currency name to 'Bolívar Soberano' - Move the currency VEF to historical currencies - Correct the currency name for PHILIPPINES (THE): Philippine Peso (instead of Piso) - Change the country name: SWAZILAND to ESWATINI
Webrev: http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
Build and test passed on mach5 for all platforms.
Thanks, Leo
Hello, Should these changes have CSR requests? Cheers, -Joe On 8/28/2018 10:09 AM, Naoto Sato wrote:
Hi Leo,
Looks good to me. Also, please work with sustaining wrt backports.
Naoto
On 8/28/18 7:56 AM, li.jiang@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169
Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for consistent.
Changes include:
- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 minor 2 - Update the currency name to 'Bolívar Soberano' - Move the currency VEF to historical currencies - Correct the currency name for PHILIPPINES (THE): Philippine Peso (instead of Piso) - Change the country name: SWAZILAND to ESWATINI
Webrev: http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
Build and test passed on mach5 for all platforms.
Thanks, Leo
Hi Joe, This is a typical currency data change, and does not involve any public interface changes, so I think CSR is not needed. We haven't filed CSRs for such changes in the past. Naoto On 8/28/18 6:33 PM, joe darcy wrote:
Hello,
Should these changes have CSR requests?
Cheers,
-Joe
On 8/28/2018 10:09 AM, Naoto Sato wrote:
Hi Leo,
Looks good to me. Also, please work with sustaining wrt backports.
Naoto
On 8/28/18 7:56 AM, li.jiang@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169
Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for consistent.
Changes include:
- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 minor 2 - Update the currency name to 'Bolívar Soberano' - Move the currency VEF to historical currencies - Correct the currency name for PHILIPPINES (THE): Philippine Peso (instead of Piso) - Change the country name: SWAZILAND to ESWATINI
Webrev: http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
Build and test passed on mach5 for all platforms.
Thanks, Leo
Hi Naoto, Thanks for checking; cheers, -Joe On 8/28/2018 6:44 PM, naoto.sato@oracle.com wrote:
Hi Joe,
This is a typical currency data change, and does not involve any public interface changes, so I think CSR is not needed. We haven't filed CSRs for such changes in the past.
Naoto
On 8/28/18 6:33 PM, joe darcy wrote:
Hello,
Should these changes have CSR requests?
Cheers,
-Joe
On 8/28/2018 10:09 AM, Naoto Sato wrote:
Hi Leo,
Looks good to me. Also, please work with sustaining wrt backports.
Naoto
On 8/28/18 7:56 AM, li.jiang@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169
Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for consistent.
Changes include:
- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 minor 2 - Update the currency name to 'Bolívar Soberano' - Move the currency VEF to historical currencies - Correct the currency name for PHILIPPINES (THE): Philippine Peso (instead of Piso) - Change the country name: SWAZILAND to ESWATINI
Webrev: http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
Build and test passed on mach5 for all platforms.
Thanks, Leo
participants (5)
-
joe darcy
-
Joseph D. Darcy
-
li.jiang＠oracle.com
-
Naoto Sato
-
naoto.sato＠oracle.com