I18NJarTest.java L29: Is -XDignore.symbol.file really needed? As far as I see, the test only uses the public APIs. L79: should it check if the returned value is false? Otherwise, looks good. Mandy On 1/10/2012 1:06 PM, Kumar Srinivasan wrote:

sorry I pasted the wrong webrev in the email, here is the right one... http://cr.openjdk.java.net/~ksrini/7125442/

Kumar

...

Hi,

Please review: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442

Webrev: http://cr.openjdk.java.net/~ksrini/7124443/

Thanks Kumar

On 1/10/2012 1:44 PM, Kumar Srinivasan wrote:

...

I18NJarTest.java L29: Is -XDignore.symbol.file really needed? As far as I see, the test only uses the public APIs.

This is needed, since TestHelper uses javac and tar apis behind the scenes.

Ah. I missed its reference to sun.tools.jar.Main. It uses javax.tools.ToolProvider and JavaCompiler API and so sun.tools.jar api is the only one.

...

L79: should it check if the returned value is false?

IMO not necessary, if mkdir fails then createJar will throw exception.

Okay. Thanks. Mandy

On 01/10/2012 01:14 PM, Mandy Chung wrote:

I18NJarTest.java L29: Is -XDignore.symbol.file really needed? As far as I see, the test only uses the public APIs. L79: should it check if the returned value is false?

Otherwise, looks good.

Looks fine, -Joe

Mandy

On 1/10/2012 1:06 PM, Kumar Srinivasan wrote:

...

sorry I pasted the wrong webrev in the email, here is the right one... http://cr.openjdk.java.net/~ksrini/7125442/

Kumar

...

Hi,

Please review: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442

Webrev: http://cr.openjdk.java.net/~ksrini/7124443/

Thanks Kumar