RFR: 8177814: jdk/editpad is not in jdk TEST.groups
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`. Additional testing: - [x] `jdk_editpad` is passing ------------- Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/5648/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5648&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8177814 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5648.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5648/head:pull/5648 PR: https://git.openjdk.java.net/jdk/pull/5648
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`.
Additional testing: - [x] `jdk_editpad` is passing
There is also one such test in the test/hotspot. @prrace Not sure what is the best fix for this. Probably the test automation should run the headful tests from t1/2/3/etc instead of just jdk_desktop? ------------- PR: https://git.openjdk.java.net/jdk/pull/5648
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`.
Additional testing: - [x] `jdk_editpad` is passing
Anyhow, how do you want to proceed with this PR? ------------- PR: https://git.openjdk.java.net/jdk/pull/5648
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`.
Additional testing: - [x] `jdk_editpad` is passing
Let's fix it this way ------------- Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5648
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`.
Additional testing: - [x] `jdk_editpad` is passing
Ok, thanks! ------------- PR: https://git.openjdk.java.net/jdk/pull/5648
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`.
Additional testing: - [x] `jdk_editpad` is passing
This pull request has now been integrated. Changeset: cfe7471f Author: Aleksey Shipilev <shade@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/cfe7471f1769eca2a4e623f5ba9cddceb005... Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8177814: jdk/editpad is not in jdk TEST.groups Reviewed-by: serb ------------- PR: https://git.openjdk.java.net/jdk/pull/5648
participants (2)
-
Aleksey Shipilev
-
Sergey Bylokhov