On Oct 1, 2012, at 7:35 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:

On 01/10/2012 14:14, Paul Sandoz wrote:

...

Hi,

See here:

http://cr.openjdk.java.net/~psandoz/tl/7197642/webrev/

Thanks, Paul. If I have it right, this "moves" the NPE from the ServiceLoader's iterator methods to the load* methods where the check should have been.

Yes, more specifically the first call to Iterator.getNext(), and an somewhat obfuscated NPE would have been thrown.

It's a subtle behavior change but I think it's okay for a major release.

The test looks good except that it's partying like it's 1999 :-)

:-)

I'm happy to sponsor this and I can fix up the copyright date before pushing the change. I'll leave it until tomorrow to give other a chance to jump in if they wish.

Thanks, Paul.