RFR: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs. ------------- Commit messages: - 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules Changes: https://git.openjdk.java.net/jdk/pull/3904/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3904&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266646 Stats: 38 lines in 4 files changed: 27 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/3904.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904 PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Could those be replaced with just `Instant.now()`? `Instant.toString()` uses the same formatter as `ISO_INSTANT`. ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Use + Instant.now(); Instant.toString() uses the same formatter as ISO_INSTANT. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3904/files - new: https://git.openjdk.java.net/jdk/pull/3904/files/f027f8e0..3e6b436c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3904&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3904&range=00-01 Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/3904.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904 PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
Use + Instant.now(); Instant.toString() uses the same formatter as ISO_INSTANT.
Looks good. I guess you could also remove `DateTimeFormatter` import statement now. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
Use + Instant.now(); Instant.toString() uses the same formatter as ISO_INSTANT.
Doh. Done. ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Oh - good point Naoto! Thanks for the suggestion. Done. ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: removed unused import statement ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3904/files - new: https://git.openjdk.java.net/jdk/pull/3904/files/3e6b436c..c101347a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3904&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3904&range=01-02 Stats: 4 lines in 4 files changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3904.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904 PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
removed unused import statement
Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
removed unused import statement
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
removed unused import statement
Marked as reviewed by bpb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
removed unused import statement
Marked as reviewed by lancea (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
This pull request has now been integrated. Changeset: 3fcdc50e Author: Daniel Fuchs <dfuchs@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/3fcdc50e4425b10181a2a3d82718994597dc... Stats: 34 lines in 4 files changed: 23 ins; 2 del; 9 mod 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules Reviewed-by: naoto, iris, bpb, lancea ------------- PR: https://git.openjdk.java.net/jdk/pull/3904
participants (5)
-
Brian Burkhalter
-
Daniel Fuchs
-
Iris Clark
-
Lance Andersen
-
Naoto Sato