Spliterator documentation on Priority(Blocking)Queue
Hello! The PriorityQueue class iterator() returns elements in no particular order. This is explicitly stated in JavaDoc for iterator() method [1] as well as in class description [2]. However it's not mentioned mentioned that spliterator() method also traverses the queue in no particular order. Well, the user might guess that the order is not specified, because the spliterator does not have ORDERED characteristic, but it's not so obvious for any user. Probably it's would be good to add an explicit note like it's done for iterator. The same thing is for PriorityBlockingQueue. What do you think? With best regards, Tagir Valeev. [1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar... [2] http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar...
Hi Tagir, Can you log an issue? Thanks, Paul. On 4 Aug 2015, at 06:47, Tagir Valeev <amaembo@gmail.com> wrote:
Hello!
The PriorityQueue class iterator() returns elements in no particular order. This is explicitly stated in JavaDoc for iterator() method [1] as well as in class description [2]. However it's not mentioned mentioned that spliterator() method also traverses the queue in no particular order. Well, the user might guess that the order is not specified, because the spliterator does not have ORDERED characteristic, but it's not so obvious for any user. Probably it's would be good to add an explicit note like it's done for iterator. The same thing is for PriorityBlockingQueue. What do you think?
With best regards, Tagir Valeev.
[1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar... [2] http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar...
Hello, Paul. I think I have no access rights to do it. Should I have to sign an OCA for this? I submitted the signed OCA to oracle-ca_us@oracle.com last week (as you suggested in ConstantSpliterator discussion), but still got no response. Probably I did something wrong. With best regards, Tagir Valeev. On Tue, Aug 4, 2015 at 1:56 PM, Paul Sandoz <paul.sandoz@oracle.com> wrote:
Hi Tagir,
Can you log an issue?
Thanks, Paul.
On 4 Aug 2015, at 06:47, Tagir Valeev <amaembo@gmail.com> wrote:
Hello!
The PriorityQueue class iterator() returns elements in no particular order. This is explicitly stated in JavaDoc for iterator() method [1] as well as in class description [2]. However it's not mentioned mentioned that spliterator() method also traverses the queue in no particular order. Well, the user might guess that the order is not specified, because the spliterator does not have ORDERED characteristic, but it's not so obvious for any user. Probably it's would be good to add an explicit note like it's done for iterator. The same thing is for PriorityBlockingQueue. What do you think?
With best regards, Tagir Valeev.
[1]
http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar...
[2]
http://hg.openjdk.java.net/jdk9/dev/jdk/file/022d45d94d0a/src/java.base/shar...
On 4 Aug 2015, at 11:18, Tagir Valeev <amaembo@gmail.com> wrote:
Hello, Paul.
I think I have no access rights to do it.
You can do it here: http://bugreport.java.com/ (Write access to the Java Bug System requires OpenJDK author status.)
Should I have to sign an OCA for this?
No.
I submitted the signed OCA to oracle-ca_us@oracle.com last week (as you suggested in ConstantSpliterator discussion), but still got no response. Probably I did something wrong.
It’s probably because people are busy. If you have it can you forward me (personally) the email you sent and i will try and ping people. Thanks, Paul.
Hello! You can do it here:
(Write access to the Java Bug System requires OpenJDK author status.)
Thank you for the clarification. I filed the issue with Review ID: JI-9023040.
It’s probably because people are busy. If you have it can you forward me (personally) the email you sent and i will try and ping people.
I forwarded that mail to you. Thank you in advance, With best regards, Tagir Valeev.
On 4 Aug 2015, at 13:42, Tagir Valeev <amaembo@gmail.com> wrote:
Hello!
You can do it here:
(Write access to the Java Bug System requires OpenJDK author status.)
Thank you for the clarification. I filed the issue with Review ID: JI-9023040.
Thanks, and here it is migrated: https://bugs.openjdk.java.net/browse/JDK-8132964 Paul.
participants (2)
-
Paul Sandoz
-
Tagir Valeev