[15] RFR: 8216332: Grapheme regex does not work with emoji sequences
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8216332 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8216332/webrev.00/ Before this fix, the rule GB11 (Do not break within emoji modifier sequences or emoji zwj sequences [1]) was only applied once, and was ignored thereafter for the repeated possible rule candidates. The fix is to simply stop resetting the GB11 mode. Naoto [1] https://unicode.org/reports/tr29/#GB11
Ping. Any takers? Naoto On 3/5/20 8:58 AM, naoto.sato@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8216332
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8216332/webrev.00/
Before this fix, the rule GB11 (Do not break within emoji modifier sequences or emoji zwj sequences [1]) was only applied once, and was ignored thereafter for the repeated possible rule candidates. The fix is to simply stop resetting the GB11 mode.
Naoto
Hi Naoto, The fix looks fine and the set of test cases looks good too. Roger On 3/5/20 11:58 AM, naoto.sato@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8216332
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8216332/webrev.00/
Before this fix, the rule GB11 (Do not break within emoji modifier sequences or emoji zwj sequences [1]) was only applied once, and was ignored thereafter for the repeated possible rule candidates. The fix is to simply stop resetting the GB11 mode.
Naoto
participants (2)
-
naoto.sato＠oracle.com
-
Roger Riggs