RFR: 8377905: gcc.md included with every build
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant. Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected. ------------- Commit messages: - 8377905: gcc.md included with every build Changes: https://git.openjdk.org/jdk/pull/29853/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29853&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8377905 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29853.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29853/head:pull/29853 PR: https://git.openjdk.org/jdk/pull/29853
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29853#pullrequestreview-3834648917
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
Marked as reviewed by jsjolen (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29853#pullrequestreview-3834663945
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
LGTM. This change seems very simple .. seems like it would be OK for 26 GA. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29853#pullrequestreview-3834745124
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
Much simpler than I had anticipated. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29853#pullrequestreview-3835160056
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
Thank you for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/29853#issuecomment-3948168728
On Fri, 20 Feb 2026 22:38:20 GMT, Mikael Vidstedt <mikael@openjdk.org> wrote:
JDK-8377509 added the gcc.md license file. Unfortunately the file is unconditionally in the built JDK regardless of the toolchain used. This change updates the build logic to only include the file when relevant.
Testing: tier1, builds-tier[2-5], manual verification to ensure the file is only included where expected.
This pull request has now been integrated. Changeset: c0c1775a Author: Mikael Vidstedt <mikael@openjdk.org> URL: https://git.openjdk.org/jdk/commit/c0c1775a2b002e82347bb0a0b1167cfe45e7006e Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8377905: gcc.md included with every build Reviewed-by: erikj, jsjolen, prr, dholmes ------------- PR: https://git.openjdk.org/jdk/pull/29853
participants (5)
-
David Holmes
-
Erik Joelsson
-
Johan Sjölen
-
Mikael Vidstedt
-
Phil Race