Looks good to me.  This is very low risk and no objection from me to fix in 10. Mandy On 1/23/18 11:12 AM, Paul Sandoz wrote:

Hi,

Please review:

http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8195970-varhandle-buffer-view-... <http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8195970-varhandle-buffer-view-null/webrev/>

The ByteBuffer view VarHandle implements were (embarrassingly) missing a null check on the ByteBuffer argument. Checks were added and so were tests.

I am proposing this be fixed in 10 via the fix request process [1].

Thanks, Paul.

[1] http://openjdk.java.net/projects/jdk/10/fix-request-process <http://openjdk.java.net/projects/jdk/10/fix-request-process>