RFR 8218195: [testlibrary] Diagnostic output for test library ProcessTools
Please review the addition of diagnostic output to the test library ProcessTools.executeProcess to aid in diagnosing several unexplained timeouts. It adds a second check for process being aliev using ProcessHandle and prints information about the current process and its descendents and all processes. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-pt-alive-patch-1/ Thanks, Roger
Hi Roger, it looks like we might get false-positive "Process terminated unexpectedly" w/ this patch and as JDK-8218197 seems to better explain the evidence, I don't think we need this patch at all. Thanks, -- Igor
On Feb 1, 2019, at 8:47 AM, Roger Riggs <Roger.Riggs@Oracle.com> wrote:
Please review the addition of diagnostic output to the test library ProcessTools.executeProcess to aid in diagnosing several unexplained timeouts.
It adds a second check for process being aliev using ProcessHandle and prints information about the current process and its descendents and all processes.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-pt-alive-patch-1/
Thanks, Roger
Hi Igor, ok, no need to add useless code. And yes there might be timing issue; but the output is purely diagnostic and it does not throw an exception so by itself would not cause the test to misbehave. Roger On 02/01/2019 12:19 PM, Igor Ignatyev wrote:
Hi Roger,
it looks like we might get false-positive "Process terminated unexpectedly" w/ this patch and as JDK-8218197 seems to better explain the evidence, I don't think we need this patch at all.
Thanks, -- Igor
On Feb 1, 2019, at 8:47 AM, Roger Riggs <Roger.Riggs@Oracle.com> wrote:
Please review the addition of diagnostic output to the test library ProcessTools.executeProcess to aid in diagnosing several unexplained timeouts.
It adds a second check for process being aliev using ProcessHandle and prints information about the current process and its descendents and all processes.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-pt-alive-patch-1/
Thanks, Roger
Hi Roger, Looks good to me - although it might hide bugs in Process.waitFor ? best regards, -- daniel On 01/02/2019 16:47, Roger Riggs wrote:
Please review the addition of diagnostic output to the test library ProcessTools.executeProcess to aid in diagnosing several unexplained timeouts.
It adds a second check for process being aliev using ProcessHandle and prints information about the current process and its descendents and all processes.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-pt-alive-patch-1/
Thanks, Roger
participants (3)
-
Daniel Fuchs
-
Igor Ignatyev
-
Roger Riggs