RFR: 8271840: Add simple Integer.toString microbenchmarks
This adds Integer.toString microbenchmarks, roughly similar to the Long.toString microbenchmarks (toStringSmall should use an equivalent data set). This is useful for comparison purposes and completeness. Also tuned existing benchmarks to harmonize setup, reduce runtime without significantly harming reliability of results, and remove the explicit Threads.MAX from Longs ------------- Commit messages: - Add simple Integer.toString microbenchmarks Changes: https://git.openjdk.java.net/jdk/pull/4988/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4988&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271840 Stats: 43 lines in 2 files changed: 33 ins; 3 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/4988.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4988/head:pull/4988 PR: https://git.openjdk.java.net/jdk/pull/4988
On Wed, 4 Aug 2021 07:46:48 GMT, Claes Redestad <redestad@openjdk.org> wrote:
This adds Integer.toString microbenchmarks, roughly similar to the Long.toString microbenchmarks (toStringSmall should use an equivalent data set). This is useful for comparison purposes and completeness.
Also tuned existing benchmarks to harmonize setup, reduce runtime without significantly harming reliability of results, and remove the explicit Threads.MAX from Longs
Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4988
On Wed, 4 Aug 2021 08:04:48 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
Looks fine.
Thanks! ------------- PR: https://git.openjdk.java.net/jdk/pull/4988
On Wed, 4 Aug 2021 07:46:48 GMT, Claes Redestad <redestad@openjdk.org> wrote:
This adds Integer.toString microbenchmarks, roughly similar to the Long.toString microbenchmarks (toStringSmall should use an equivalent data set). This is useful for comparison purposes and completeness.
Also tuned existing benchmarks to harmonize setup, reduce runtime without significantly harming reliability of results, and remove the explicit Threads.MAX from Longs
This pull request has now been integrated. Changeset: 55bd52a1 Author: Claes Redestad <redestad@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/55bd52a14283033d66cd7bf1deadb31c040b... Stats: 43 lines in 2 files changed: 33 ins; 3 del; 7 mod 8271840: Add simple Integer.toString microbenchmarks Reviewed-by: shade ------------- PR: https://git.openjdk.java.net/jdk/pull/4988
participants (2)
-
Aleksey Shipilev
-
Claes Redestad