[jdk16] RFR: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation
Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin). The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t. Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic implementations. Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange checkIndexes. Please review this patch which fixes the above issue. Best Regards, Sandhya ------------- Commit messages: - 8259213: Vector conversion with part > 0 is not getting intrinsic implementation Changes: https://git.openjdk.java.net/jdk16/pull/79/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=79&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259213 Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk16/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/79/head:pull/79 PR: https://git.openjdk.java.net/jdk16/pull/79
On Tue, 5 Jan 2021 01:03:55 GMT, Sandhya Viswanathan <sviswanathan@openjdk.org> wrote:
Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin). The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t. Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic implementations. Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange checkIndexes.
Please review this patch which fixes the above issue.
Best Regards, Sandhya
Looks good. Can you please update the copyright year before integrating? I notice the issue is not assigned to you, unsure of Skara will make it so once integrated. ------------- Marked as reviewed by psandoz (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/79
On Tue, 5 Jan 2021 15:51:08 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
update copyright year
Looks good. Can you please update the copyright year before integrating?
I notice the issue is not assigned to you, unsure of Skara will make it so once integrated.
@PaulSandoz Thanks a lot for the review. I have updated the copyright year. Please let me know if I can go ahead and integrate. ------------- PR: https://git.openjdk.java.net/jdk16/pull/79
On Tue, 5 Jan 2021 15:51:08 GMT, Paul Sandoz <psandoz@openjdk.org> wrote:
Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
update copyright year
Looks good. Can you please update the copyright year before integrating?
I notice the issue is not assigned to you, unsure of Skara will make it so once integrated.
@PaulSandoz Thanks a lot for the review. I have updated the copyright year. Please let me know if I can go ahead and integrate.
All good. ------------- PR: https://git.openjdk.java.net/jdk16/pull/79
Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin). The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t. Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic implementations. Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange checkIndexes.
Please review this patch which fixes the above issue.
Best Regards, Sandhya
Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision: update copyright year ------------- Changes: - all: https://git.openjdk.java.net/jdk16/pull/79/files - new: https://git.openjdk.java.net/jdk16/pull/79/files/c283812f..29ed8e43 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk16&pr=79&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk16&pr=79&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk16/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/79/head:pull/79 PR: https://git.openjdk.java.net/jdk16/pull/79
On Tue, 5 Jan 2021 01:03:55 GMT, Sandhya Viswanathan <sviswanathan@openjdk.org> wrote:
Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin). The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t. Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic implementations. Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange checkIndexes.
Please review this patch which fixes the above issue.
Best Regards, Sandhya
This pull request has now been integrated. Changeset: 50bf4330 Author: Sandhya Viswanathan <sviswanathan@openjdk.org> URL: https://git.openjdk.java.net/jdk16/commit/50bf4330 Stats: 10 lines in 2 files changed: 6 ins; 0 del; 4 mod 8259213: Vector conversion with part > 0 is not getting intrinsic implementation Reviewed-by: psandoz ------------- PR: https://git.openjdk.java.net/jdk16/pull/79
participants (2)
-
Paul Sandoz
-
Sandhya Viswanathan