Review request 8154837: Class::getPackage with exploded modules when classes in modules defined to the boot loader
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154837/webrev.00/ The module location from an exploded image is file URL rather than file path. This issue can be reproduced with jdk/test/java/lang/Package/GetPackages.java on windows. Mandy
On 21 Apr 2016, at 23:03, Mandy Chung <mandy.chung@oracle.com> wrote:
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154837/webrev.00/
This looks good to me Mandy. -Chris.
The module location from an exploded image is file URL rather than file path. This issue can be reproduced with jdk/test/java/lang/Package/GetPackages.java on windows.
Mandy
On 21/04/2016 23:03, Mandy Chung wrote:
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154837/webrev.00/
The module location from an exploded image is file URL rather than file path. This issue can be reproduced with jdk/test/java/lang/Package/GetPackages.java on windows. This looks okay, maybe slightly better if it starts for "file:/".
At some point then I think we need to re-examine the underlying JVM function to see if we can get it to return a file URL for -Xbootclasspath/a case too. That is, it's a bit strange for the function to return a String that is sometimes a URL, sometimes a file path. -Alan
On Apr 21, 2016, at 11:31 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
On 21/04/2016 23:03, Mandy Chung wrote:
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154837/webrev.00/
The module location from an exploded image is file URL rather than file path. This issue can be reproduced with jdk/test/java/lang/Package/GetPackages.java on windows. This looks okay, maybe slightly better if it starts for "file:/“.
Will patch before the push.
At some point then I think we need to re-examine the underlying JVM function to see if we can get it to return a file URL for -Xbootclasspath/a case too. That is, it's a bit strange for the function to return a String that is sometimes a URL, sometimes a file path.
I agree and it’d be better to be consistent. I will file an issue to track this. Mandy
participants (3)
-
Alan Bateman
-
Chris Hegarty
-
Mandy Chung