RFR: JDK-8272866 java.util.random package summary contains incorrect mixing function in table
The table 'LXM Multipliers' at the end of the javadoc for the java.util.random package states that the mixing function is mixLea32 for all the 64/128-bit LCG based generators. This should be updated to mixLea64 for the 64/128-bit LCG generators. Only the L32X64MixRandom which uses a 32-bit LCG will use the mixLea32 mixing function. ------------- Commit messages: - Correct table entries Changes: https://git.openjdk.java.net/jdk/pull/5279/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5279&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272866 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/5279.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5279/head:pull/5279 PR: https://git.openjdk.java.net/jdk/pull/5279
On Fri, 27 Aug 2021 14:20:32 GMT, Jim Laskey <jlaskey@openjdk.org> wrote:
The table 'LXM Multipliers' at the end of the javadoc for the java.util.random package states that the mixing function is mixLea32 for all the 64/128-bit LCG based generators. This should be updated to mixLea64 for the 64/128-bit LCG generators. Only the L32X64MixRandom which uses a 32-bit LCG will use the mixLea32 mixing function.
Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/5279
On Fri, 27 Aug 2021 14:20:32 GMT, Jim Laskey <jlaskey@openjdk.org> wrote:
The table 'LXM Multipliers' at the end of the javadoc for the java.util.random package states that the mixing function is mixLea32 for all the 64/128-bit LCG based generators. This should be updated to mixLea64 for the 64/128-bit LCG generators. Only the L32X64MixRandom which uses a 32-bit LCG will use the mixLea32 mixing function.
This pull request has now been integrated. Changeset: e66c8afb Author: Jim Laskey <jlaskey@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/e66c8afb59b57c4546656efa97f723f08496... Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8272866: java.util.random package summary contains incorrect mixing function in table Reviewed-by: rriggs ------------- PR: https://git.openjdk.java.net/jdk/pull/5279
participants (2)
-
Jim Laskey
-
Roger Riggs