[15] RFR: 8242010: Upgrade IANA Language Subtag Registry to Version 2020-04-01
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8242010 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8242010/webrev.00/ Besides the upgrade of the data file, I fixed the issue where EquivMapsGenerator had been ignoring "extlang" tag. Now it correctly maps the extlang, such as "zh-cmn" to its preferred language (in this case, "cmn") tag. Naoto
Hi Naoto, Looks fine. In EquivMapsGenerator.java. typo: grandfahered -> grandfathered Thanks, Roger On 4/7/20 1:52 PM, naoto.sato@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8242010
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8242010/webrev.00/
Besides the upgrade of the data file, I fixed the issue where EquivMapsGenerator had been ignoring "extlang" tag. Now it correctly maps the extlang, such as "zh-cmn" to its preferred language (in this case, "cmn") tag.
Naoto
Thanks Roger. I will fix the typo before the push. Naoto On 4/7/20 12:47 PM, Roger Riggs wrote:
Hi Naoto,
Looks fine.
In EquivMapsGenerator.java. typo:
grandfahered -> grandfathered Thanks, Roger
On 4/7/20 1:52 PM, naoto.sato@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8242010
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8242010/webrev.00/
Besides the upgrade of the data file, I fixed the issue where EquivMapsGenerator had been ignoring "extlang" tag. Now it correctly maps the extlang, such as "zh-cmn" to its preferred language (in this case, "cmn") tag.
Naoto
+1 Best, Joe On 4/7/20 12:48 PM, naoto.sato@oracle.com wrote:
Thanks Roger. I will fix the typo before the push.
Naoto
On 4/7/20 12:47 PM, Roger Riggs wrote:
Hi Naoto,
Looks fine.
In EquivMapsGenerator.java. typo:
grandfahered -> grandfathered Thanks, Roger
On 4/7/20 1:52 PM, naoto.sato@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8242010
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8242010/webrev.00/
Besides the upgrade of the data file, I fixed the issue where EquivMapsGenerator had been ignoring "extlang" tag. Now it correctly maps the extlang, such as "zh-cmn" to its preferred language (in this case, "cmn") tag.
Naoto
participants (3)
-
Joe Wang
-
naoto.sato＠oracle.com
-
Roger Riggs