RFR: JDK-8276650: GenGraphs does not produce deterministic output
The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them. ------------- Commit messages: - JDK-8276650: GenGraphs does not produce deterministic output Changes: https://git.openjdk.java.net/jdk/pull/6266/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6266&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276650 Stats: 41 lines in 2 files changed: 2 ins; 1 del; 38 mod Patch: https://git.openjdk.java.net/jdk/pull/6266.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6266/head:pull/6266 PR: https://git.openjdk.java.net/jdk/pull/6266
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung <mchung@openjdk.org> wrote:
The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6266
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung <mchung@openjdk.org> wrote:
The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them.
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java line 336:
334: private final String name; 335: private final Graph<String> graph; 336: private final TreeSet<ModuleDescriptor> descriptors = new TreeSet<>();
This change is unnecessary, isn't it? ------------- PR: https://git.openjdk.java.net/jdk/pull/6266
On Thu, 4 Nov 2021 21:46:21 GMT, Anthony Vanelverdinghe <duke@openjdk.java.net> wrote:
The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them.
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java line 336:
334: private final String name; 335: private final Graph<String> graph; 336: private final TreeSet<ModuleDescriptor> descriptors = new TreeSet<>();
This change is unnecessary, isn't it?
This will make it clear that this is sorted. ------------- PR: https://git.openjdk.java.net/jdk/pull/6266
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung <mchung@openjdk.org> wrote:
The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them.
This pull request has now been integrated. Changeset: e21b5c7b Author: Mandy Chung <mchung@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/e21b5c7b3781430ecf568e7f5c89ef3391e0... Stats: 41 lines in 2 files changed: 2 ins; 1 del; 38 mod 8276650: GenGraphs does not produce deterministic output Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/jdk/pull/6266
participants (3)
-
Anthony Vanelverdinghe
-
Iris Clark
-
Mandy Chung