[jdk17] RFR: 8271155: Wrong path separator in env variable
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher. ------------- Commit messages: - 8271155: Wrong path separator in env variable Changes: https://git.openjdk.java.net/jdk17/pull/271/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=271&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271155 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/271/head:pull/271 PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Marked as reviewed by herrick (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Looks good. Is there a unit test associated with this? If not, do you think one would be useful? ------------- Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Marked as reviewed by almatvee (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
This pull request has now been integrated. Changeset: 7165b3f1 Author: Alexey Semenyuk <asemenyuk@openjdk.org> URL: https://git.openjdk.java.net/jdk17/commit/7165b3f105621398d7673253b6324e97ba... Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8271155: Wrong path separator in env variable Reviewed-by: herrick, kcr, iris, almatvee ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
There is no unit test covering this area. I'll file follow up CR to add one in JDK18. ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Is there a test planned for this change or is it covered by an existing test? Just asking as this has been committed to openjdk/jdk17 and wondering what the test coverage is. ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher.
Alexey filed [JDK-8271170](https://bugs.openjdk.java.net/browse/JDK-8271170) to cover this. ------------- PR: https://git.openjdk.java.net/jdk17/pull/271
participants (6)
-
Alan Bateman
-
Alexander Matveev
-
Alexey Semenyuk
-
Andy Herrick
-
Iris Clark
-
Kevin Rushforth