RFR: 8277059: Use blessed modifier order in java.xml
I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. ------------- Commit messages: - 8277059: Use blessed modifier order in java.xml Changes: https://git.openjdk.java.net/jdk/pull/6369/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6369&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277059 Stats: 505 lines in 140 files changed: 0 ins; 0 del; 505 mod Patch: https://git.openjdk.java.net/jdk/pull/6369.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6369/head:pull/6369 PR: https://git.openjdk.java.net/jdk/pull/6369
On Fri, 12 Nov 2021 15:06:35 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:
I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.
Thanks, Magnus. However, we've discussed the issue for sources from the 3rd party, and we'd like it keep it that way to facilitate any future merges. Refer to JDK-8264019 / https://github.com/openjdk/jdk/pull/3091. ------------- PR: https://git.openjdk.java.net/jdk/pull/6369
On Fri, 12 Nov 2021 15:06:35 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:
I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.
I understand. I just checked the git history and saw that there were other code hygiene changes. I'll close this issue then. ------------- PR: https://git.openjdk.java.net/jdk/pull/6369
On Fri, 12 Nov 2021 15:06:35 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:
I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/6369
participants (2)
-
Joe Wang
-
Magnus Ihse Bursie