Review request: 8152502: tools/jdeps/modules/GenModuleInfo.java and TransitiveDeps fails on windows
These jdeps tests fails running on windows “Error. failed clean up files after test”. A bug in the tests and implementation that calls Files.walk without try-with-resources. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152502/webrev.00/index.html This fix calls Files::walk with try-with-resources. I wasn’t quite able to reproduce the error on my windows machine. I’d like to push this fix and address any issue, if any. Mandy
Looks good to me. -- Jon On 05/19/2016 04:50 PM, Mandy Chung wrote:
These jdeps tests fails running on windows “Error. failed clean up files after test”. A bug in the tests and implementation that calls Files.walk without try-with-resources.
Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152502/webrev.00/index.html
This fix calls Files::walk with try-with-resources. I wasn’t quite able to reproduce the error on my windows machine. I’d like to push this fix and address any issue, if any.
Mandy
participants (2)
-
Jonathan Gibbons
-
Mandy Chung