RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
8258422: Cleanup unnecessary null comparison before instanceof check in java.base ------------- Commit messages: - [PATCH] Cleanup unnecessary null comparison before instanceof check in java.base Changes: https://git.openjdk.java.net/jdk/pull/20/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258422 Stats: 42 lines in 21 files changed: 0 ins; 0 del; 42 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
I believe this changes is useful and still actual: 1. improve code to make it easier to read. 2. performance should be improved a bit too ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Sun, 4 Oct 2020 11:55:50 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
I believe this changes is useful and still actual: 1. improve code to make it easier to read. 2. performance should be improved a bit too
I’ll see if I can get somebody to take a look at this. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Sat, 31 Oct 2020 19:37:10 GMT, Stuart Marks <smarks@openjdk.org> wrote:
I believe this changes is useful and still actual: 1. improve code to make it easier to read. 2. performance should be improved a bit too
I’ll see if I can get somebody to take a look at this.
This seems like a reasonable change, which improves readability. My preference is to wait a little longer (hopefully no more than a couple of weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern Matching for instanceof" is finalised, then we can remove the explicit casts in many of these cases. For example: --- a/src/java.base/share/classes/java/io/File.java +++ b/src/java.base/share/classes/java/io/File.java @@ -2191,8 +2191,8 @@ public class File * {@code false} otherwise */ public boolean equals(Object obj) { - if ((obj != null) && (obj instanceof File)) { - return compareTo((File)obj) == 0; + if (obj instanceof File file) { + return compareTo(file) == 0; } return false; } ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Mon, 2 Nov 2020 09:15:31 GMT, Chris Hegarty <chegar@openjdk.org> wrote:
I’ll see if I can get somebody to take a look at this.
This seems like a reasonable change, which improves readability.
My preference is to wait a little longer (hopefully no more than a couple of weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern Matching for instanceof" is finalised, then we can remove the explicit casts in many of these cases. For example:
--- a/src/java.base/share/classes/java/io/File.java +++ b/src/java.base/share/classes/java/io/File.java @@ -2191,8 +2191,8 @@ public class File * {@code false} otherwise */ public boolean equals(Object obj) { - if ((obj != null) && (obj instanceof File)) { - return compareTo((File)obj) == 0; + if (obj instanceof File file) { + return compareTo(file) == 0; } return false; }
Related issue - https://bugs.openjdk.java.net/browse/JDK-8257448 ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 2 Dec 2020 20:15:02 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
This seems like a reasonable change, which improves readability.
My preference is to wait a little longer (hopefully no more than a couple of weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern Matching for instanceof" is finalised, then we can remove the explicit casts in many of these cases. For example:
--- a/src/java.base/share/classes/java/io/File.java +++ b/src/java.base/share/classes/java/io/File.java @@ -2191,8 +2191,8 @@ public class File * {@code false} otherwise */ public boolean equals(Object obj) { - if ((obj != null) && (obj instanceof File)) { - return compareTo((File)obj) == 0; + if (obj instanceof File file) { + return compareTo(file) == 0; } return false; }
Related issue - https://bugs.openjdk.java.net/browse/JDK-8257448
Hi @turbanoff, I've logged a JBS issue for tracking this change: https://bugs.openjdk.java.net/browse/JDK-8258422 JEP 394 is finalized now, so I guess you could follow-up Chris suggestion to remove the explicit casts. After the fix is properly reviewed and marked as ready for the integration (you'll need to issue `/integrate` command), once it is done I would happily `/sponsor` the change. With Best Regards, Aleksei ------------- PR: https://git.openjdk.java.net/jdk/pull/20
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - 8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching - 8258422: Cleanup unnecessary null comparison before instanceof check in java.base ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/f09bbd24..603cd364 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=00-01 Stats: 784681 lines in 7664 files changed: 596718 ins; 128884 del; 59079 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Tue, 15 Dec 2020 19:52:31 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- 8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching - 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 803:
801: if (obj instanceof WindowsPath path) { 802: return compareTo(path) == 0; 803: }
Can you do the same in UnixPath? ------------- PR: https://git.openjdk.java.net/jdk/pull/20
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching in UnixPath too ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/603cd364..0d2ac405 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching in UnixPath too
Let's take advantage of "flow scoping" to eliminate some of these casts. A few examples follow. src/java.base/share/classes/java/net/InetSocketAddress.java line 414:
412: if (!(obj instanceof InetSocketAddress)) 413: return false; 414: return holder.equals(((InetSocketAddress) obj).holder);
If we restructure this a little we can get: public final boolean equals(Object obj) { if (obj instanceof InetSocketAddress that) return holder.equals(that.holder); return false; } src/java.base/share/classes/java/net/InetSocketAddress.java line 124:
122: if (!(obj instanceof InetSocketAddressHolder)) 123: return false; 124: InetSocketAddressHolder that = (InetSocketAddressHolder)obj;
If we restructure this a little we can take advantage of flow scoping, e.g. public final boolean equals(Object obj) { if (!(obj instanceof InetSocketAddressHolder that)) return false; boolean sameIP; if (addr != null) sameIP = addr.equals(that.addr); else if (hostname != null) sameIP = (that.addr == null) && hostname.equalsIgnoreCase(that.hostname); else sameIP = (that.addr == null) && (that.hostname == null); return sameIP && (port == that.port); } ------------- Changes requested by chegar (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 09:44:37 GMT, Chris Hegarty <chegar@openjdk.org> wrote:
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching in UnixPath too
Let's take advantage of "flow scoping" to eliminate some of these casts. A few examples follow.
Hi Andrey, Could you, please, also take a look at `java.net.Socket`: java/net/Socket.java: if (bindpoint != null && (!(bindpoint instanceof InetSocketAddress))) java/net/Socket.java- throw new IllegalArgumentException("Unsupported address type"); And `HttpURLConnection`: sun/net/www/protocol/http/HttpURLConnection.java: if (a != null && c instanceof HttpURLConnection) { sun/net/www/protocol/http/HttpURLConnection.java- ((HttpURLConnection)c).setAuthenticator(a); The following cmd was used to find them: `rgrep -A 1 "= null .* instanceof "` ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 18:27:35 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
Let's take advantage of "flow scoping" to eliminate some of these casts. A few examples follow.
Hi Andrey,
Could you, please, also take a look at `java.net.Socket`: java/net/Socket.java: if (bindpoint != null && (!(bindpoint instanceof InetSocketAddress))) java/net/Socket.java- throw new IllegalArgumentException("Unsupported address type"); And `HttpURLConnection`: sun/net/www/protocol/http/HttpURLConnection.java: if (a != null && c instanceof HttpURLConnection) { sun/net/www/protocol/http/HttpURLConnection.java- ((HttpURLConnection)c).setAuthenticator(a); The following cmd was used to find them: `rgrep -A 1 "= null .* instanceof "`
@AlekseiEfimov in both cases removing `null` check will change semantic of the code. Comparison is not redundant. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Dec 16, 2020, at 1:47 AM, Chris Hegarty <chegar@openjdk.java.net> wrote:
On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base use instanceof pattern matching in UnixPath too
Let's take advantage of "flow scoping" to eliminate some of these casts. A few examples follow.
src/java.base/share/classes/java/net/InetSocketAddress.java line 414:
412: if (!(obj instanceof InetSocketAddress)) 413: return false; 414: return holder.equals(((InetSocketAddress) obj).holder);
If we restructure this a little we can get:
public final boolean equals(Object obj) { if (obj instanceof InetSocketAddress that) return holder.equals(that.holder); return false; }
It’s also possible to use a ternary expression as in: return (obj instanceof InetSocketAddress that) ? holder.equals(that.holder) : false; Not suggesting you have to do that here. More for information purposes for those that might not know. Paul.
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/0d2ac405..f5727ca9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=02-03 Stats: 42 lines in 12 files changed: 1 ins; 10 del; 31 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts
Looks good to me. ------------- Marked as reviewed by chegar (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts
src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
100: */ 101: public boolean equals(Object other) { 102: if (this == other) {
It might be a bit cleaner to rename Object other to "obj" to avoid having Object other and Signal other1. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Thu, 17 Dec 2020 10:29:50 GMT, Alan Bateman <alanb@openjdk.org> wrote:
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts
src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
100: */ 101: public boolean equals(Object other) { 102: if (this == other) {
It might be a bit cleaner to rename Object other to "obj" to avoid having Object other and Signal other1.
Actually, I'm not sure if `oth` is better name for variable than `other1`. I would say they have the same rank :) ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Thu, 17 Dec 2020 11:35:26 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
100: */ 101: public boolean equals(Object other) { 102: if (this == other) {
It might be a bit cleaner to rename Object other to "obj" to avoid having Object other and Signal other1.
Actually, I'm not sure if `oth` is better name for variable than `other1`. I would say they have the same rank :)
I believe Alan is suggesting to do: /** * Compares the equality of two <code>Signal</code> objects. * * @param obj the object to compare with. * @return whether two <code>Signal</code> objects are equal. */ public boolean equals(Object obj) { if (this == obj) { this leaves the variable name `other` free for later use inside the method. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Thu, 17 Dec 2020 13:32:06 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:
Actually, I'm not sure if `oth` is better name for variable than `other1`. I would say they have the same rank :)
I believe Alan is suggesting to do:
/** * Compares the equality of two <code>Signal</code> objects. * * @param obj the object to compare with. * @return whether two <code>Signal</code> objects are equal. */ public boolean equals(Object obj) { if (this == obj) {
this leaves the variable name `other` free for later use inside the method.
Actually, I'm not sure if `oth` is better name for variable than `other1`. I would say they have the same rank :)
Sorry, I should have been clearer, the comment was about equals(Object other). If you rename "other" then it will avoid "other1" ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts
Thank you for checking `HttpURLConnection` and `Socket`. The latest version looks good to me. ------------- Marked as reviewed by aefimov (Committer). PR: https://git.openjdk.java.net/jdk/pull/20
On Thu, 17 Dec 2020 13:16:31 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base take advantage of "flow scoping" to eliminate casts
Thank you for checking `HttpURLConnection` and `Socket`. The latest version looks good to me.
This issue is blocked by [8258657][1]. It should not be integrated until after 8258657 has been resolved. The JIRA issues have been linked up to reflect this. [1]: https://bugs.openjdk.java.net/browse/JDK-8258657 ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Sat, 19 Dec 2020 10:29:23 GMT, Chris Hegarty <chegar@openjdk.org> wrote:
Thank you for checking `HttpURLConnection` and `Socket`. The latest version looks good to me.
This issue is blocked by [8258657][1]. It should not be integrated until after 8258657 has been resolved. The JIRA issues have been linked up to reflect this.
[JDK-8258657](https://bugs.openjdk.java.net/browse/JDK-8258657) has been resolved. The changes reverted by [JDK-8258696](https://bugs.openjdk.java.net/browse/JDK-8258696) could also be re-applied to `HttpClientImpl` class. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Fri, 8 Jan 2021 13:20:38 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
This issue is blocked by [8258657][1]. It should not be integrated until after 8258657 has been resolved. The JIRA issues have been linked up to reflect this.
[JDK-8258657](https://bugs.openjdk.java.net/browse/JDK-8258657) has been resolved. The changes reverted by [JDK-8258696](https://bugs.openjdk.java.net/browse/JDK-8258696) could also be re-applied to `HttpClientImpl` class.
@AlekseiEfimov Yes please. Whatever is easier, include the changes to HttpClientImpl in this PR, or followup separately. Otherwise, I see no reason why this PR cannot proceed. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/f5727ca9..314217ec Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=03-04 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Thu, 17 Dec 2020 14:01:14 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
src/java.base/share/classes/jdk/internal/misc/Signal.java line 101:
99: * @return whether two <code>Signal</code> objects are equal. 100: */ 101: public boolean equals(Object oth) {
I'd suggest to replace `oth` with `obj` and fix the `@param` clause in the method javadoc. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base rename 'other' -> 'oth', 'other1' -> 'other' ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/314217ec..fe303a2c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base rename 'oth' -> 'obj' ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/20/files - new: https://git.openjdk.java.net/jdk/pull/20/files/fe303a2c..5949f9a8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=06 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=20&range=05-06 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk/pull/20
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Hi @turbanoff, This PR is ready for integration - `JDK-8258657` has been resolved. You can proceed with issuing `integrate` bot command. Then I will `sponsor` it. But before that, I would like to ask if you would like to take on board the changes to `HttpClientImpl`? Alternatively, I can follow it up separately and reapply the backed-out change under different bugID. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Mon, 11 Jan 2021 16:57:00 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
Hi @turbanoff, This PR is ready for integration - `JDK-8258657` has been resolved. You can proceed with issuing `integrate` bot command. Then I will `sponsor` it. But before that, I would like to ask if you would like to take on board the changes to `HttpClientImpl`? Alternatively, I can follow it up separately and reapply the backed-out change under different bugID.
@AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think it's better to not touch it under this PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Mon, 11 Jan 2021 17:12:24 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
Hi @turbanoff, This PR is ready for integration - `JDK-8258657` has been resolved. You can proceed with issuing `integrate` bot command. Then I will `sponsor` it. But before that, I would like to ask if you would like to take on board the changes to `HttpClientImpl`? Alternatively, I can follow it up separately and reapply the backed-out change under different bugID.
@AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think it's better to not touch it under this PR.
To double check that docs build will be stable after integration the following actions have been performed: - The pull request branch was locally synced-up with the latest changes from `master` (`JDK-8258657` is part of them) - Verified that local `docs-reference-api-javadoc` build completes successfully ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Mon, 11 Jan 2021 23:29:53 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
@AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think it's better to not touch it under this PR.
To double check that docs build will be stable after integration the following actions have been performed: - The pull request branch was locally synced-up with the latest changes from `master` (`JDK-8258657` is part of them) - Verified that local `docs-reference-api-javadoc` build completes successfully
sponsor ------------- PR: https://git.openjdk.java.net/jdk/pull/20
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov <github.com+741251+turbanoff@openjdk.org> wrote:
8258422: Cleanup unnecessary null comparison before instanceof check in java.base
This pull request has now been integrated. Changeset: 022bc9f0 Author: Andrey Turbanov <turbanoff@gmail.com> Committer: Aleksei Efimov <aefimov@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/022bc9f0 Stats: 82 lines in 22 files changed: 1 ins; 13 del; 68 mod 8258422: Cleanup unnecessary null comparison before instanceof check in java.base Reviewed-by: chegar, aefimov ------------- PR: https://git.openjdk.java.net/jdk/pull/20
participants (7)
-
Alan Bateman
-
Aleksei Efimov
-
Andrey Turbanov
-
Chris Hegarty
-
Daniel Fuchs
-
Paul Sandoz
-
Stuart Marks