On 16/07/2014 13:58, Paul Sandoz wrote:

Hi,

There was discussion here:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026458.html

https://bugs.openjdk.java.net/browse/JDK-4774077

http://cr.openjdk.java.net/~rwarburton/buffer-overrides-1/ <http://cr.openjdk.java.net/%7Erwarburton/buffer-overrides-1/>

The patch looks good.

Looks good okay to me too except that @inheritDoc doesn't inherit the runtime exceptions so I assume that @throws will need to be added to ensure that the javadoc is complete. -Alan.

Hi, [Including compiler-dev, i am not on that list so please CC me if replying to just that list] I dropped this, then JVMLS got in the way... then J1 got in the way.... so i better get to this before Devoxx gets in the way... Richard, thanks for your continued patience. In the interim Richard made a slight tweak to the patch and some tests were updated to avoid casts: http://cr.openjdk.java.net/~rwarburton/buffer-overrides-3/ This looks good. Reviewed! BUT in the interim some warnings were enabled and now javac fails to compile: /Users/sandoz/Projects/jdk9/dev/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/util/BaseFileManager.java:245: warning: [cast] redundant cast to CharBuffer return (CharBuffer)CharBuffer.allocate(1).flip(); ^ /Users/sandoz/Projects/jdk9/dev/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/util/BaseFileManager.java:329: warning: [cast] redundant cast to ByteBuffer put((ByteBuffer)result.flip()); ^ /Users/sandoz/Projects/jdk9/dev/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/util/BaseFileManager.java:336: warning: [cast] redundant cast to ByteBuffer return (ByteBuffer)result.flip(); ^ /Users/sandoz/Projects/jdk9/dev/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/util/BaseFileManager.java:352: warning: [cast] redundant cast to ByteBuffer ? (ByteBuffer)cached.clear() ^ /Users/sandoz/Projects/jdk9/dev/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java:81: warning: [cast] redundant cast to CharBuffer return ((CharBuffer)buffer.compact().flip()).array(); ^ error: warnings found and -Werror specified So Richard has a patch for that too: http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtool... This is required because in the bootstrap compilation phase a JDK without the co-variant overrides can be used. So the current solution is to suppress the warnings. Reviews from langtools gurus are very much appreciated. Ideally it would be nice to push all this under one issue, is that possible? If not i will have to create another issue and of course push to langtools before jdk. A internal CCC is also underway. Paul.