RFR: 8379166: Upstream redundant diffs fixed in Valhalla - Part 1
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld. ------------- Commit messages: - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla Changes: https://git.openjdk.org/jdk/pull/29944/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29944&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8379166 Stats: 51 lines in 14 files changed: 7 ins; 9 del; 35 mod Patch: https://git.openjdk.org/jdk/pull/29944.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29944/head:pull/29944 PR: https://git.openjdk.org/jdk/pull/29944
On Thu, 26 Feb 2026 21:36:40 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Nice cleanup. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29944#issuecomment-3969458272
On Thu, 26 Feb 2026 21:36:40 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
I think I collected sufficient differences for a patch. Please notify me if you think this cleanup patch needs to bump copyright years. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29944#issuecomment-3995138987
On Thu, 26 Feb 2026 21:36:40 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Tier 1-2 on linux x64 passed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29944#issuecomment-3995399077
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Problem spotted by Roger review - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29944/files - new: https://git.openjdk.org/jdk/pull/29944/files/bd49a097..05d33060 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29944&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29944&range=00-01 Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29944.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29944/head:pull/29944 PR: https://git.openjdk.org/jdk/pull/29944
On Wed, 4 Mar 2026 05:58:54 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Problem spotted by Roger review - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla
Looks good. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29944#pullrequestreview-3890536954
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Update comment for consistency with Valhalla patch - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Problem spotted by Roger review - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29944/files - new: https://git.openjdk.org/jdk/pull/29944/files/05d33060..cf013e21 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29944&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29944&range=01-02 Stats: 1121 lines in 26 files changed: 862 ins; 105 del; 154 mod Patch: https://git.openjdk.org/jdk/pull/29944.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29944/head:pull/29944 PR: https://git.openjdk.org/jdk/pull/29944
On Wed, 4 Mar 2026 17:42:41 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Update comment for consistency with Valhalla patch - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Problem spotted by Roger review - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla
Marked as reviewed by rriggs (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29944#pullrequestreview-3891458621
On Wed, 4 Mar 2026 17:42:41 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Update comment for consistency with Valhalla patch - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Problem spotted by Roger review - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - More diff - Merge branch 'master' of https://github.com/openjdk/jdk into fix/valhalla-cleans - Upstream some redundant diffs fixed in Valhalla
Thanks so much for the renewed approval! Since the incremental change is comment only and passes local build, and the previous revision passed tier 1-2 on linux x64, I will be integrating. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29944#issuecomment-3999835820
On Thu, 26 Feb 2026 21:36:40 GMT, Chen Liang <liach@openjdk.org> wrote:
In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.
This pull request has now been integrated. Changeset: 9d1d0c6f Author: Chen Liang <liach@openjdk.org> URL: https://git.openjdk.org/jdk/commit/9d1d0c6f0553c5f042351d1def385589015fefd6 Stats: 51 lines in 15 files changed: 5 ins; 9 del; 37 mod 8379166: Upstream redundant diffs fixed in Valhalla - Part 1 Reviewed-by: rriggs ------------- PR: https://git.openjdk.org/jdk/pull/29944
participants (2)
-
Chen Liang
-
Roger Riggs