Review request for JDK-8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518
Hi, Joe and all Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924? The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/. I have verified this fix, the corresponding test(it will be pushed with another test suite) and jaxp test are passed in JPRT. Thanks, Frank
Hi Frank, Fix looks good to me (not a reviewer). Did you have a chance to run JCK tests with proposed fix? Also we'll need to backport this change. Do you have a plan to do it? If not then I can handle it. With Best Regards, Aleksej On 08/25/2015 12:43 PM, Frank Yuan wrote:
Hi, Joe and all
Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/.
I have verified this fix, the corresponding test(it will be pushed with another test suite) and jaxp test are passed in JPRT.
Thanks,
Frank
Hi Aleksej and Lance Many thanks for your reminder! I have run JCK test today, all xml tests are passed. To Aleksej Please help me to handle the backport, thank you very much! Best Regards Frank -----Original Message----- From: Aleksej Efimov [mailto:aleksej.efimov@oracle.com] Sent: Tuesday, August 25, 2015 7:18 PM To: Frank Yuan <frank.yuan@oracle.com> Cc: 'core-libs-dev' <core-libs-dev@openjdk.java.net>; 'Joe Wang' <huizhe.wang@oracle.com> Subject: Re: Review request for JDK-8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518 Hi Frank, Fix looks good to me (not a reviewer). Did you have a chance to run JCK tests with proposed fix? Also we'll need to backport this change. Do you have a plan to do it? If not then I can handle it. With Best Regards, Aleksej On 08/25/2015 12:43 PM, Frank Yuan wrote:
Hi, Joe and all
Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/.
I have verified this fix, the corresponding test(it will be pushed with another test suite) and jaxp test are passed in JPRT.
Thanks,
Frank
Hi Frank This looks OK. I am assuming you have run the TCK/JCK tests just to validate there are no surprises based on the change prior to pushing ? Best Lance On Aug 25, 2015, at 5:43 AM, Frank Yuan <frank.yuan@oracle.com> wrote:
Hi, Joe and all
Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/.
I have verified this fix, the corresponding test(it will be pushed with another test suite) and jaxp test are passed in JPRT.
Thanks,
Frank
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com
Looks good to me. Thanks, Joe On 8/25/2015 2:43 AM, Frank Yuan wrote:
Hi, Joe and all
Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/ <http://cr.openjdk.java.net/%7Efyuan/8133924/webrev.00/>.
I have verified this fix, the corresponding test(it will be pushed with another test suite) and jaxp test are passed in JPRT.
Thanks,
Frank
participants (4)
-
Aleksej Efimov
-
Frank Yuan
-
huizhe wang
-
Lance Andersen