RFR: 8263658: Use the blessed modifier order in java.base
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required. ------------- Commit messages: - 8263658: Use the blessed modifier order in java.base Changes: https://git.openjdk.java.net/jdk/pull/3094/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3094&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263658 Stats: 19 lines in 5 files changed: 0 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/jdk/pull/3094.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3094/head:pull/3094 PR: https://git.openjdk.java.net/jdk/pull/3094
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required.
Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3094
On Fri, 19 Mar 2021 18:31:02 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required.
Marked as reviewed by naoto (Reviewer).
Can't reuse the bug IDs, sadly. Filed https://bugs.openjdk.java.net/browse/JDK-8263892 (note the new summary name to disambiguate) ------------- PR: https://git.openjdk.java.net/jdk/pull/3094
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3094
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required.
Marked as reviewed by redestad (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3094
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt <github.com+76791+alblue@openjdk.org> wrote:
Additional changes found in `java.base` of `final private` -> `private final`. Filed with existing bug because it's the same module; can change to a different bug number if required.
This pull request has now been integrated. Changeset: 77ebc110 Author: Alex Blewitt <alex.blewitt@gmail.com> Committer: Claes Redestad <redestad@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/77ebc110 Stats: 19 lines in 5 files changed: 0 ins; 0 del; 19 mod 8263892: More modifier order fixes in java.base Reviewed-by: naoto, iris, redestad ------------- PR: https://git.openjdk.java.net/jdk/pull/3094
participants (4)
-
Alex Blewitt
-
Claes Redestad
-
Iris Clark
-
Naoto Sato