[jdk17] RFR: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use. ------------- Commit messages: - Extend delay before destorying child to allow more vm startup to complete. Changes: https://git.openjdk.java.net/jdk17/pull/228/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=228&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269929 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/228/head:pull/228 PR: https://git.openjdk.java.net/jdk17/pull/228
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/228
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use.
+1 ------------- Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/228
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use.
Looks good. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/228
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use.
This pull request has now been integrated. Changeset: c812bbbe Author: Roger Riggs <rriggs@openjdk.org> URL: https://git.openjdk.java.net/jdk17/commit/c812bbbe8fe86fe960eebfe5c1ce224251... Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output Reviewed-by: iris, bpb, naoto ------------- PR: https://git.openjdk.java.net/jdk17/pull/228
participants (4)
-
Brian Burkhalter
-
Iris Clark
-
Naoto Sato
-
Roger Riggs