RFR 9: 8081566: java/lang/ProcessHandle/InfoTest.java failed on case sensitive command
Please review this testbug fix to correctly check the reported command name. On Windows the command filename may differ only by case and should be checked to see if they are the same file, not just the same string. webrev: http://cr.openjdk.java.net/~rriggs/webrev-infotest-8081566/ Issue: https://bugs.openjdk.java.net/browse/JDK-8081566 Thanks, Roger
Hi Roger, The changes all seem reasonable Best Lance On Jun 1, 2015, at 9:57 AM, Roger Riggs <Roger.Riggs@oracle.com> wrote:
Please review this testbug fix to correctly check the reported command name. On Windows the command filename may differ only by case and should be checked to see if they are the same file, not just the same string.
webrev: http://cr.openjdk.java.net/~rriggs/webrev-infotest-8081566/
Issue: https://bugs.openjdk.java.net/browse/JDK-8081566
Thanks, Roger
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com
On 01/06/2015 14:57, Roger Riggs wrote:
Please review this testbug fix to correctly check the reported command name. On Windows the command filename may differ only by case and should be checked to see if they are the same file, not just the same string. File path comparison is case insensitive on Windows so equals would work if the path Strings were obtaining from actual file paths. This doesn't seem to be case here so using isSameFile make sense.
-Alan.
participants (3)
-
Alan Bateman
-
Lance Andersen
-
Roger Riggs