[11] RFR(S) : 8205687 : TimeoutHandler generates huge core files
http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html
18 lines changed: 3 ins; 5 del; 10 mod;
Hi all, could you please review this small fix for TimeoutHandler? gcore dumps non committed memory, which is a problem when JVM is run w/ ZGC or in other configurations where memory is reserved but not committed. the fix replaces invocation of gcore w/ 'kill -ABRT'. as kill has to be the last command run by TimeoutHandler, I've changed jdk.test.failurehandler.ToolKit to run action after we get a list of the process's children and also changed GathererFactory to run "common" part before os-specific part. NB 'kill' will generate core file only if a host has appropriate core file limit and core file handling settings, therefore you might observe that core files aren't generated if your hosts aren't set up correspondingly. JBS: https://bugs.openjdk.java.net/browse/JDK-8205687 webrev: http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html Thanks, -- Igor
Hi Igor, This all seems okay. However we probably need to check that the people operating their own build/test farms are okay with this change. Don't forget to update copyright years. Minor comment below ... On 8/08/2018 7:19 AM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html
18 lines changed: 3 ins; 5 del; 10 mod;
Hi all,
could you please review this small fix for TimeoutHandler? gcore dumps non committed memory, which is a problem when JVM is run w/ ZGC or in other configurations where memory is reserved but not committed. the fix replaces invocation of gcore w/ 'kill -ABRT'. as kill has to be the last command run by TimeoutHandler, I've changed jdk.test.failurehandler.ToolKit to run action after we get a list of the process's children and also changed GathererFactory to run "common" part before os-specific part.
Can you add a comment in GathererFactory to explain that as well please. Thanks, David
NB 'kill' will generate core file only if a host has appropriate core file limit and core file handling settings, therefore you might observe that core files aren't generated if your hosts aren't set up correspondingly.
JBS: https://bugs.openjdk.java.net/browse/JDK-8205687 webrev: http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html
Thanks, -- Igor
Hi David, thanks for your review. I've updated copyright years and added the next comment in GathererFactory.java:
+ // os-specific action set must be last, b/c they can kill the process
regarding checking w/ the people operating their own farms, I agree it'd be nice to do for changes like this one, but I don't know a better channel to do other than an email to dev alias, which wouldn't be much different from this RFR. In this particular case, I expect the hosts in all test farms to have core dumping enabled and core dumps from crashes are, from my observations, used more frequently than dumps from timeouts, so it shouldn't cause big issues. Thanks, -- Igor
On Aug 7, 2018, at 9:00 PM, David Holmes <david.holmes@oracle.com> wrote:
Hi Igor,
This all seems okay. However we probably need to check that the people operating their own build/test farms are okay with this change.
Don't forget to update copyright years.
Minor comment below ...
On 8/08/2018 7:19 AM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html
18 lines changed: 3 ins; 5 del; 10 mod; Hi all, could you please review this small fix for TimeoutHandler? gcore dumps non committed memory, which is a problem when JVM is run w/ ZGC or in other configurations where memory is reserved but not committed. the fix replaces invocation of gcore w/ 'kill -ABRT'. as kill has to be the last command run by TimeoutHandler, I've changed jdk.test.failurehandler.ToolKit to run action after we get a list of the process's children and also changed GathererFactory to run "common" part before os-specific part.
Can you add a comment in GathererFactory to explain that as well please.
Thanks, David
NB 'kill' will generate core file only if a host has appropriate core file limit and core file handling settings, therefore you might observe that core files aren't generated if your hosts aren't set up correspondingly. JBS: https://bugs.openjdk.java.net/browse/JDK-8205687 webrev: http://cr.openjdk.java.net/~iignatyev//8205687/webrev.00/index.html Thanks, -- Igor
participants (2)
-
David Holmes
-
Igor Ignatyev