Code review request: 7151348: Build breaks due to warning clean up in sun.rmi.*(7146763)
Hi, jdk8 build is breaking if SKIP_BOOT_CYCLE is set to false due to some changes made as a part of warnings cleanup in sun.rmi.* (see 7146763) that are incompatible with the code in the corba respository. This CR is simply to revert back the changes made to files in sun/rmi/rmic for the time being. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151348 (Not available yet) Webrev: http://cr.openjdk.java.net/~khazra/7151348/webrev.00/ Thanks, Kurchi
On 3/5/12 5:13 PM, Kurchi Hazra wrote:
jdk8 build is breaking if SKIP_BOOT_CYCLE is set to false due to some changes made as a part of warnings cleanup in sun.rmi.* (see 7146763) that are incompatible with the code in the corba respository. This CR is simply to revert back the changes made to files in sun/rmi/rmic for the time being.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151348 (Not available yet)
Webrev: http://cr.openjdk.java.net/~khazra/7151348/webrev.00/
OK, looks good. (Of course, that's what I said during the last round of review, which ended up breaking the build.) :-) Actually I think I see the problem. In the original changeset, sun/rmi/rmic/Main.java was changed as follows: - environmentClass = envClass; + environmentClass = BatchEnvironment.class.asSubclass(environmentClass); This should have been + environmentClass = BatchEnvironment.class.asSubclass(envClass); I don't know for sure that this causes the problem but it sure seems suspicious. Anyway, go ahead push these changes as they stand. We'll work on the modified rmic changes later, and push them after having done more boot cycle testing. Thanks! s'marks
On 3/5/12 5:33 PM, Stuart Marks wrote:
Actually I think I see the problem. In the original changeset, sun/rmi/rmic/Main.java was changed as follows:
- environmentClass = envClass; + environmentClass = BatchEnvironment.class.asSubclass(environmentClass);
This should have been
+ environmentClass = BatchEnvironment.class.asSubclass(envClass);
... Which won't even compile. Instead it probably should have been: + environmentClass = envClass.asSubclass(BatchEnvironment.class); Whoops. OK, at least now we know how to run boot cycle builds. :-) s'marks
participants (2)
-
Kurchi Hazra
-
Stuart Marks