[jdk17] RFR: JDK-8269426: Move tests from test/jdk/java/lang/invoke/t8150782 to its parent directory
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory. ------------- Commit messages: - JDK-8269426: Move tests from test/jdk/java/lang/invoke/t8150782 to its parent directory Changes: https://git.openjdk.java.net/jdk17/pull/162/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=162&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269426 Stats: 9 lines in 6 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk17/pull/162.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/162/head:pull/162 PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung <mchung@openjdk.org> wrote:
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
Hi Mandy, It looks like the test in question has some test support files associated with it (p/Foo.java & q/Bar.java). I personally think it's nice if tests like these are in a separate directory, so that it's easier to see which test support files belong to which test (and to avoid potential name clashes when 2 tests want to use a support file with the same name). How would you feel about dropping just the `t` prefix from the test directory & package names? Then it would match the existing tests in `<bugid>` directories. ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung <mchung@openjdk.org> wrote:
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
That's a fair point. I personally prefer using a descriptive directory name rather than bug ID since that can give the reader what the tests are intended for. What about renaming `t8150782` to `accessClassAndFindClass`? ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 18:56:24 GMT, Mandy Chung <mchung@openjdk.org> wrote:
That's a fair point. I personally prefer using a descriptive directory name rather than bug ID since that can give the reader what the tests are intended for. What about renaming t8150782 to accessClassAndFindClass?
Me too! That sounds like an excellent idea :) ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: Keep the tests under a directory ------------- Changes: - all: https://git.openjdk.java.net/jdk17/pull/162/files - new: https://git.openjdk.java.net/jdk17/pull/162/files/43cf6670..a7f8b892 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17&pr=162&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17&pr=162&range=00-01 Stats: 0 lines in 6 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/162.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/162/head:pull/162 PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 19:13:45 GMT, Mandy Chung <mchung@openjdk.org> wrote:
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
Keep the tests under a directory
Marked as reviewed by jvernee (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung <mchung@openjdk.org> wrote:
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
Thanks Jorn. ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung <mchung@openjdk.org> wrote:
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory. As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.
This pull request has now been integrated. Changeset: 56240690 Author: Mandy Chung <mchung@openjdk.org> URL: https://git.openjdk.java.net/jdk17/commit/56240690f62f9048a45a53525efccffdec... Stats: 9 lines in 6 files changed: 0 ins; 0 del; 9 mod 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass Reviewed-by: jvernee ------------- PR: https://git.openjdk.java.net/jdk17/pull/162
participants (2)
-
Jorn Vernee
-
Mandy Chung