[PATCH] Review Request: 7076644 TEST_BUG: test/java/io/File/Basic.java fails with cygwin
Hi Alan, Can you please help to review the fix below for bug http://monaco.us.oracle.com/detail.jsf?cr=7076644? http://dl.dropbox.com/u/90659131/fixes/7076644/webrev/index.html As discussed, it is caused a known issue of cygwin that chmod doesn't work, see http://cygwin.com/faq/faq-nochunks.html#faq.using.chmod. The fix is to replace "chmod ugo-w" to dos command "attrib +R" when test is executed in CYGWIN or MKS. Thanks, Eric
On 07/08/2012 08:00, Eric Wang wrote:
Hi Alan,
Can you please help to review the fix below for bug http://monaco.us.oracle.com/detail.jsf?cr=7076644?
http://dl.dropbox.com/u/90659131/fixes/7076644/webrev/index.html
As discussed, it is caused a known issue of cygwin that chmod doesn't work, see http://cygwin.com/faq/faq-nochunks.html#faq.using.chmod. The fix is to replace "chmod ugo-w" to dos command "attrib +R" when test is executed in CYGWIN or MKS. Thanks Eric, it good to another test off the exclude list. Minor comment is that the other shell tests check for Windows* rather than Windows_*, I can change it for you when pushing the fix.
-Alan
participants (2)
-
Alan Bateman
-
Eric Wang